Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump proc-macro-crate to 3.1.0 #8

Merged
merged 5 commits into from
May 8, 2024

Conversation

tdimitrov
Copy link
Contributor

Hey @drahnr. Long time no see :)

I'm trying to get this fix for proc-macro-crate fixed in a project (polkadot-sdk) where fatality is a dependency. For this reason I'm tracking all crates depending on proc-macro-create and bumping the versions. Fatality is one such project.

Do you see a problem with using the latest proc-macro-crate in fatality?

proc-macro/src/types.rs Outdated Show resolved Hide resolved
tests/ui/err-01.stderr Outdated Show resolved Hide resolved
Copy link
Owner

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to retain the Bar(kw::foo) to keep the span information, otherwise LGTM! Thank you!

@drahnr drahnr merged commit d6578e5 into drahnr:master May 8, 2024
3 checks passed
@drahnr
Copy link
Owner

drahnr commented May 8, 2024

I'll cut a new release on Friday morning early CEST, if not done by 9am, please ping me here.

@tdimitrov
Copy link
Contributor Author

@drahnr ping for the release 🙏

@drahnr
Copy link
Owner

drahnr commented May 9, 2024

Not quite Friday yet ;)

@tdimitrov
Copy link
Contributor Author

tdimitrov commented May 9, 2024

Not quite Friday yet ;)

https://www.isitfridayyet.net/

I'm loosing track for the day of the week, Sorry about that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants