-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure in vendor
dir
#48
Comments
The error message suggests that |
Does it help to change let manifest_dir = env::var("CARGO_MANIFEST_DIR").map_err(|_| Error::CargoManifestDirNotSet)?; to let mut manifest_dir = env::var("CARGO_MANIFEST_DIR").map_err(|_| Error::CargoManifestDirNotSet)?;
if manifest_dir.is_empty() {
manifest_dir = ".".to_owned();
} |
Thanks for the hint! |
I guess its one of the subsequent calls to to |
Besides releasing a new version, this fixes an issue with vendored deps. Closes: #48
fix-proc-macro-crate.patch contains a fix for bkchr/proc-macro-crate#48
This PR bumps `proc-macro-crate` to the latest version. In order to test a runtime from https://github.com/polkadot-fellows/runtimes/ with the latest version of polkadot-sdk one needs to use `cargo vendor` to extract all runtime dependencies, patch them by hand and then build the runtime. However at the moment 'vendored' builds fail due to bkchr/proc-macro-crate#48. To fix this `proc-macro-crate` should be updated to version `3.0.1` or higher. --------- Co-authored-by: command-bot <>
This PR bumps `proc-macro-crate` to the latest version. In order to test a runtime from https://github.com/polkadot-fellows/runtimes/ with the latest version of polkadot-sdk one needs to use `cargo vendor` to extract all runtime dependencies, patch them by hand and then build the runtime. However at the moment 'vendored' builds fail due to bkchr/proc-macro-crate#48. To fix this `proc-macro-crate` should be updated to version `3.0.1` or higher. --------- Co-authored-by: command-bot <>
Besides releasing a new version, this fixes an issue with vendored deps. Closes: bkchr/proc-macro-crate#48
Besides releasing a new version, this fixes an issue with vendored deps. Closes: bkchr/proc-macro-crate#48
This PR bumps `proc-macro-crate` to the latest version. In order to test a runtime from https://github.com/polkadot-fellows/runtimes/ with the latest version of polkadot-sdk one needs to use `cargo vendor` to extract all runtime dependencies, patch them by hand and then build the runtime. However at the moment 'vendored' builds fail due to bkchr/proc-macro-crate#48. To fix this `proc-macro-crate` should be updated to version `3.0.1` or higher. --------- Co-authored-by: command-bot <>
This PR bumps `proc-macro-crate` to the latest version. In order to test a runtime from https://github.com/polkadot-fellows/runtimes/ with the latest version of polkadot-sdk one needs to use `cargo vendor` to extract all runtime dependencies, patch them by hand and then build the runtime. However at the moment 'vendored' builds fail due to bkchr/proc-macro-crate#48. To fix this `proc-macro-crate` should be updated to version `3.0.1` or higher. --------- Co-authored-by: command-bot <>
This PR bumps `proc-macro-crate` to the latest version. In order to test a runtime from https://github.com/polkadot-fellows/runtimes/ with the latest version of polkadot-sdk one needs to use `cargo vendor` to extract all runtime dependencies, patch them by hand and then build the runtime. However at the moment 'vendored' builds fail due to bkchr/proc-macro-crate#48. To fix this `proc-macro-crate` should be updated to version `3.0.1` or higher. --------- Co-authored-by: command-bot <>
Fails to build after doing a
cargo vendor
in one downstream repo, eg: https://github.com/polkadot-fellows/runtimesI think its this line:
proc-macro-crate/src/lib.rs
Line 255 in c9671b5
Can it just use a mocked timestamp or something?
Example error from the repo above:
The text was updated successfully, but these errors were encountered: