Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v2.3.5 #892

Merged
merged 15 commits into from
Oct 11, 2023
Merged

Release/v2.3.5 #892

merged 15 commits into from
Oct 11, 2023

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

waitingallday and others added 14 commits October 6, 2023 12:45
… being fetched client side

nuxt doesn't expose the useRequestEvent on the client, only the server so it was failing
fix(@dpc-sdp/nuxt-ripple): fixed console error when request event was…
feat(@dpc-sdp/ripple-tide-publication): added proper publication head…
fix(@dpc-sdp/ripple-tide-publication): fixed duplication side nav links
…ication menu endpoints

fixes publication menu and children not display in previews
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 3a78093
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6525e59456e1210008fe0a19

@cypress
Copy link

cypress bot commented Oct 10, 2023

Passing run #792 ↗︎

0 99 0 0 Flakiness 0

Details:

Merge branch 'develop' into release/v2.3.5
Project: ripple-framework Commit: 3a78093e17
Status: Passed Duration: 07:21 💡
Started: Oct 11, 2023 12:05 AM Ended: Oct 11, 2023 12:12 AM

Review all test suite changes for PR #892 ↗︎

@dylankelly dylankelly self-requested a review October 10, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants