Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1560] fixed console error when request event was being fetched client side #883

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jeffdowdle
Copy link
Contributor

… being fetched client side

nuxt doesn't expose the useRequestEvent on the client, only the server so it was failing

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

… being fetched client side

nuxt doesn't expose the useRequestEvent on the client, only the server so it was failing
@jeffdowdle jeffdowdle self-assigned this Oct 6, 2023
@cypress
Copy link

cypress bot commented Oct 6, 2023

Passing run #772 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/nuxt-ripple): fixed console error when request event was being fetc...
Project: ripple-framework Commit: b8f94314a5
Status: Passed Duration: 05:11 💡
Started: Oct 6, 2023 1:53 AM Ended: Oct 6, 2023 1:58 AM

Review all test suite changes for PR #883 ↗︎

@dylankelly dylankelly merged commit 5db7e84 into release/2.3.4 Oct 6, 2023
@dylankelly dylankelly changed the title fix(@dpc-sdp/nuxt-ripple): fixed console error when request event was… [R20-1560] fixed console error when request event was being fetched client side Oct 6, 2023
@waitingallday waitingallday deleted the bugfix/R20-1560-patch branch October 25, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants