Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting backwards compatibility for compilation constants #13615

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Reverting backwards compatibility for compilation constants #13615

merged 2 commits into from
Sep 16, 2020

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Sep 15, 2020 •
edited
Loading

Fixes #13377

@sfoslund sfoslund requested review from a team, dsplaisted and wli3 September 15, 2020 20:19
@sfoslund sfoslund merged commit 5f0441d into dotnet:release/5.0.1xx-rc2 Sep 16, 2020
@sfoslund sfoslund deleted the RevertDefines branch September 16, 2020 15:31
@radekdoulik radekdoulik mentioned this pull request Sep 17, 2020
Merged
@terrajobst terrajobst mentioned this pull request Sep 17, 2020
Closed
@marcpopMSFT marcpopMSFT mentioned this pull request Sep 23, 2020
Closed
radekdoulik added a commit to radekdoulik/xamarin-android that referenced this pull request Nov 10, 2020
@radekdoulik
Build with net5.0 TFM instead of netcoreapp3.1
6613ad3 
That would allow use of new NET5 API like the new dynamic dependency
[attribute](https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.dynamicdependencyattribute?view=net-5.0).

Also replace NET5_LINKER define with NET5_0. Context: dotnet/sdk#13615
radekdoulik added a commit to radekdoulik/xamarin-android that referenced this pull request Nov 10, 2020
@radekdoulik
Build with net5.0 TFM instead of netcoreapp3.1
69227ee 
That would allow use of new NET5 API like the new dynamic dependency
[attribute](https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.dynamicdependencyattribute?view=net-5.0).

Also replace NET5_LINKER define with NET5_0. Context: dotnet/sdk#13615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeloff joeloff joeloff approved these changes

@dsplaisted dsplaisted dsplaisted approved these changes

@wli3 wli3 Awaiting requested review from wli3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfoslund @dsplaisted @joeloff