-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net5/illink] Add ApplyPreserveAttribute substep #5126
[net5/illink] Add ApplyPreserveAttribute substep #5126
Conversation
Let add a test for it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check is if they can actually support [Preserve]
in .NET 6 for us, so we wouldn't have to bring this over.
@@ -8,6 +8,10 @@ | |||
|
|||
using Mono.Cecil; | |||
|
|||
#if NET5_LINKER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this #if
to NETCOREAPP3_1
and we could remove this $(DefineConstants)
?
If we change this .csproj
to TargetFramework=net5.0
later on, then NETCOREAPP3_1
will still be defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was just changed recently (dotnet/sdk#13615). So NETCOREAPP3_1
will not work. I think we should use #if NET
instead. I will try to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not defined yet in the version we are using, so I will keep NET5_LINKER
around until we have the NET
define.
For reference, this is xamarin-macios' implementation: dotnet/macios#9529 |
I would like to get this in so that we have it now. It looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should go ahead and bring this in, and we can remove it if it makes it upstream.
The ApplyPreserveAttribute susbtep was not (yet?) upstreamed, so make it build and add it to the pipeline and run it before other substeps to not break ac5269d fix.
59bf1d0
to
bbbb5d2
Compare
I will wait with adding test until the Full linker mode works, noted in #5132 to not forget it. |
The ApplyPreserveAttribute susbtep was not (yet?) upstreamed, so
make it build and add it to the pipeline and run it before other
substeps to not break ac5269d fix.