-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Fix binder gen compile issues due to inaccessible members and identifier name clashes #91967
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #91657 to release/8.0 /cc @layomia Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
c9a4c04
to
c3293ea
Compare
I've addressed all feedback on #91974. cc @eiriktsarpalis. |
c5811d2
to
95e712f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve this change for RC2. Thank you for minimizing your diff on these fixes and reusing the code from Json. @artl93 this one is ready for your review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M2 approved.
Backport of #91657 to release/8.0
/cc @layomia
Customer Impact
Fixes two reported bugs. We expect users to hit them:
Testing
Extensive unit and emitted source regression tests were added to verify the fix.
Risk
Low. Contained fix for off-by-default component. Minimal custom identifier mangling is done, instead we use more reliable Roslyn APIs.