Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit identifier formatting algorithm in config binding & JSON generators #92079

Open
layomia opened this issue Sep 14, 2023 · 1 comment
Open
Labels
area-Extensions-Configuration source-generator Indicates an issue with a source generator feature
Milestone

Comments

@layomia
Copy link
Contributor

layomia commented Sep 14, 2023

#91967 fixed issues with formatting binding helper identifiers, which caused compilation errors for certain type name conflicts. We feel that new behavior is in good shape for 8.0

The fix consolidated some logic with the JSON generator. For 9.0, we should audit both the algorithms & the shared logic, particularly to see if the abstraction makes sense in the long term. Further discussion in #91967 (comment).

@layomia layomia added area-Extensions-Configuration source-generator Indicates an issue with a source generator feature labels Sep 14, 2023
@layomia layomia added this to the 9.0.0 milestone Sep 14, 2023
@layomia layomia self-assigned this Sep 14, 2023
@ghost
Copy link

ghost commented Sep 14, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

#91967 fixed issues with formatting binding helper identifiers, which caused compilation errors for certain type name conflicts. We feel that new behavior is in good shape for 8.0

The fix consolidated some logic with the JSON generator. For 9.0, we should audit both the algorithms & the shared logic, particularly to see if the abstraction makes sense in the long term. Further discussion in #91967 (comment).

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration, source-generator

Milestone: 9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Configuration source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

No branches or pull requests

2 participants