Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DiagnosticInfo as an incremental Diagnostic replacement type. #86908

Merged
merged 7 commits into from
Jun 2, 2023
Merged

Create DiagnosticInfo as an incremental Diagnostic replacement type. #86908

merged 7 commits into from
Jun 2, 2023

Conversation

jtschuster
Copy link
Member

Creates DiagnosticInfo record to replace Diagnostic in the incremental pipeline to work around dotnet/roslyn#68291

@ghost ghost assigned jtschuster May 30, 2023
@jtschuster jtschuster requested a review from jkoritzinsky May 30, 2023 17:20
@ghost
Copy link

ghost commented May 30, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Creates DiagnosticInfo record to replace Diagnostic in the incremental pipeline to work around dotnet/roslyn#68291

Author: jtschuster
Assignees: jtschuster
Labels:

area-System.Runtime.InteropServices
Milestone: -

This was referenced May 31, 2023
Closed
Open
Closed
pavelsavara
pavelsavara approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do I understand correctly that instances of the DiagnosticInfo are created only if there is something wrong with the compiled code, so probably rarely ?

@jtschuster
Copy link
Member Author

Do I understand correctly that instances of the DiagnosticInfo are created only if there is something wrong with the compiled code, so probably rarely ?

Yes, the DiagnosticInfo instances are made by the generators when it runs into an issue with the user's code, which shouldn't be often.

@build-analysis build-analysis bot mentioned this pull request May 31, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Jun 1, 2023
Closed
@jtschuster jtschuster mentioned this pull request Jun 2, 2023
Merged
@jtschuster jtschuster merged commit c3859ad into dotnet:main Jun 2, 2023
@jtschuster jtschuster mentioned this pull request Jun 7, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@jtschuster jtschuster

Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtschuster @pavelsavara @jkoritzinsky