Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComInterfaceGenerator uses Diagnostic in incremental pipeline, which do not compare as equal in Roslyn #86736

Closed
jtschuster opened this issue May 24, 2023 · 3 comments
Closed

ComInterfaceGenerator uses Diagnostic in incremental pipeline, which do not compare as equal in Roslyn #86736

jtschuster opened this issue May 24, 2023 · 3 comments
Assignees
@jtschuster
Labels
area-System.Runtime.InteropServices
Milestone
8.0.0

Comments

@jtschuster
Copy link
Member

Diagnostics won't be incremental in the generator pipeline: dotnet/roslyn#68291

Workaround is to create a DiagnosticTemplate record with all the information required to report the diagnostic, then build the diagnostic right before reporting it.
@jtschuster jtschuster self-assigned this May 24, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 24, 2023
@ghost
Copy link

ghost commented May 24, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Diagnostics won't be incremental in the generator pipeline: dotnet/roslyn#68291

Workaround is to create a DiagnosticTemplate record with all the information required to report the diagnostic, then build the diagnostic right before reporting it.

Author: jtschuster
Assignees: jtschuster
Labels:

area-System.Runtime.InteropServices
Milestone: -

@jkoritzinsky
Copy link
Member

We should fix this for LibraryImport at the same time.

@AaronRobinsonMSFT AaronRobinsonMSFT removed the untriaged New issue has not been triaged by the area owner label May 26, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone May 26, 2023
@jtschuster
Copy link
Member Author

fixed in #86908

@ghost ghost locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jtschuster jtschuster

Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@jkoritzinsky @AaronRobinsonMSFT @jtschuster