Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0][workloads] Automatically calculate the net6 patch version #79299

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

steveisok
Copy link
Member

Automatically calculate the net6 patch version based on the net7 patch version. This is to prevent any instance where we forget to bump it manually.

Automatically calculate the net6 patch version based on the net7 patch version. This is to prevent any instance where we forget to bump it manually.
@steveisok steveisok requested a review from lewing December 6, 2022 19:05
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned steveisok Dec 6, 2022
@steveisok steveisok requested a review from mmitche December 6, 2022 19:05
@lewing
Copy link
Member

lewing commented Dec 6, 2022

main (net8) will need to know the matching downlevel net6 and net7 versions once we start inserting it as well.

cc @marcpopMSFT

@lewing lewing added this to the 7.0.x milestone Dec 6, 2022
@lewing lewing changed the title [workloads] Automatically calculate the net6 patch version [release/7.0][workloads] Automatically calculate the net6 patch version Dec 6, 2022
@marcpopMSFT
Copy link
Member

As mentioned offline, the installer repo main branch is maintained manually unfortunately, and we haven't found a solution for that. The risk of being off on the downlevel runtimes is less though for the main branch at least.

@carlossanlop
Copy link
Member

@steveisok @lewing @mmitche should we get Tactics approval for this, or can we treat it as tell-mode?

BTW CI failure is known/unrelated/already fixed: #78778

@steveisok
Copy link
Member Author

I think it's tell mode and should go in.

@carlossanlop
Copy link
Member

CI failure is known/unrelated/already fixed: #78778
Signed off.
Merging now. :shipit:

@carlossanlop carlossanlop modified the milestones: 7.0.x, 7.0.3 Jan 5, 2023
@carlossanlop carlossanlop merged commit a947c6d into dotnet:release/7.0 Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants