Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloads] downlevel workload version improvements #79304

Open
lewing opened this issue Dec 6, 2022 · 3 comments
Open

[workloads] downlevel workload version improvements #79304

lewing opened this issue Dec 6, 2022 · 3 comments
Assignees
Milestone

Comments

@lewing
Copy link
Member

lewing commented Dec 6, 2022

#79299 makes release/7.0 calculate the downlevel versions based on the current PatchVersion, this avoids situations where we forget to bump the version in the stable branches but once we start inserting net8 previews we will have to make sure multiple (net8;net7;net7) versions match here and in dotnet/emsdk with the versions we actually intend to insert.

We should also add tests to the sdk related tests that verify the downlevel versions we see in the sdk are never ahead of what is here

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 6, 2022
@lewing
Copy link
Member Author

lewing commented Dec 6, 2022

cc @marcpopMSFT @joeloff

@lewing lewing added this to the 8.0.0 milestone Dec 6, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Dec 6, 2022
@lewing lewing added untriaged New issue has not been triaged by the area owner area-Build-mono and removed untriaged New issue has not been triaged by the area owner labels Dec 6, 2022
@lewing
Copy link
Member Author

lewing commented Dec 6, 2022

We should at the least make sure our versions are in order prior to preview1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants