Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TargetFrameworks with TargetFramework where possible #66198

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 4, 2022

No description provided.

@ghost ghost assigned jkotas Mar 4, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas
Copy link
Member Author

jkotas commented Mar 4, 2022

Follow up on #66175 (comment)

@danmoseley
Copy link
Member

@ViktorHofer didn't you have some concurrent or recent change to change TargetFrameworks to TargetFramework in some way? Just want to make sure this doesn't conflict or have some wierd consequence.

@jkotas
Copy link
Member Author

jkotas commented Mar 5, 2022

The test failures are #66232 and infrastructure issue (Failed to upload results).

@jkotas jkotas merged commit 17662fc into dotnet:main Mar 5, 2022
@jkotas jkotas deleted the targetframeworks branch March 5, 2022 06:22
@ViktorHofer
Copy link
Member

@ViktorHofer didn't you have some concurrent or recent change to change TargetFrameworks to TargetFramework in some way? Just want to make sure this doesn't conflict or have some wierd consequence.

Note that there was a technical limitation that required all libraries projects to use the TargetFrameworks property even if the project wasn't multi-targeting but that was fixed with 20e8f90. Reference and source projects were updated via the same commit and test projects were then later updated with 7671b50.

The src/libraries projects touched here were either added/updated meanwhile, or my regex skills that I used to update the projects failed me 🤦 Anyway, the change looks good to me.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants