Remove the multitarget from ILCompiler.Reflection.R2R #66175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Mar 4, 2022
|
Test failure is #65791 |
| @@ -8,7 +8,7 @@ | |||
| <AssemblyKey>Open</AssemblyKey> | |||
| <IsDotNetFrameworkProductAssembly>true</IsDotNetFrameworkProductAssembly> | |||
| <!-- ILSpy requires this assembly to target netstandard2.0 --> | |||
| <TargetFrameworks>net6.0;netstandard2.0</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Post-merge nit: you can also drop the s for a tiny build-perf improvement.
There was a problem hiding this comment.
Have we ever considered a message when TargetFrameworks contains only one entry? It would be noisy of course if there were conditions involved such that sometimes it has more than one.
There was a problem hiding this comment.
Run regex find&replace to fixup all places in the repo: #66198
There was a problem hiding this comment.
The change also makes the logs easier to read, as there's no re-invocation of itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't necessary because the project doesn't have any .NET 6 dependencies anymore or trim warnings.