Fix failing SetCookies_Success test #53932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
|
The reason why it fails is because of this: Can you bump the Expires to some later date? 😄 |
|
WHAT THA HELL. Best test failure EVER 😂😂😂 |
akoeplinger
approved these changes
Jun 9, 2021
|
Hello @ViktorHofer! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
stephentoub
reviewed
Jun 9, 2021
| @@ -125,11 +125,11 @@ public static IEnumerable<object[]> SetCookiesData() | |||
| yield return new object[] | |||
| { | |||
| u, | |||
| "name98=value98; path=/; domain=.uri.com; expires=Wed, 09 Jun 2021 10:18:14 GMT, name99=value99", | |||
| "name98=value98; path=/; domain=.uri.com; expires=Wed, 09 Jun 2050 10:18:14 GMT, name99=value99", | |||
There was a problem hiding this comment.
I'll be really excited if this test is still running in 29 years and fails then.
stephentoub
approved these changes
Jun 9, 2021
|
Merging to unblock CI. |
This was referenced Jun 10, 2021
danmoseley
pushed a commit
to danmoseley/runtime
that referenced
this pull request
Jun 10, 2021
* Fix failing SetCookies_Success test
danmoseley
added a commit
that referenced
this pull request
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #53931