Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Fix failing SetCookies_Success test (#53932) #43082

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix failing SetCookies_Success test (#53932) #43082

merged 1 commit into from
Jun 10, 2021

Conversation

danmoseley
Copy link
Member

@ViktorHofer @danmoseley
Fix failing SetCookies_Success test (#53932)
a3c480e 
* Fix failing SetCookies_Success test
wtgodbe
wtgodbe approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to port to coreclr too? and runtime 5.0?

@danmoseley
Copy link
Member Author

I have another PR for 5.0

Yes, this needs to flow to CoreCLR like any test fix. For now, we can simply ignore that failure there.

@danmoseley danmoseley merged commit 2395c50 into dotnet:release/3.1 Jun 10, 2021
@danmoseley danmoseley deleted the portcookiefix branch June 10, 2021 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danmoseley @wtgodbe @Dotnet-GitSync-Bot @ViktorHofer