-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Mono iOS sample on Helix #44462
Run Mono iOS sample on Helix #44462
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
196be3e
to
7584af3
Compare
Might have to rebase to get CI to play nice. |
a436144
to
6c30fcb
Compare
33637b8
to
4e3fcd0
Compare
a47a2a6
to
baddbfb
Compare
At the moment it requires arcade helix sdk bump to, at least, version=6.0.0-beta.20577.1". |
baddbfb
to
40e64a0
Compare
According to the CI log, the sample runs as expected:
|
@akoeplinger Please give this a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should figure out why xharness return code is 42 and not 0 or 1 or 100. That seems strange to me. @fanyang-mono didn't you encounter something similar while bringing up the Android simulator runtime tests ?
@SamMonoRT It's a made up return code. We should return 0 for correctness. |
5cbee5a
to
cb209e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, left a few comments. The biggest issue for me is the Publish->Build change.
51aa8cb
to
8bdf1dc
Compare
Strange error on ios lane:
|
The PR is completely green now. |
…OS.app to helix test directory
… successful run of the sample app.
ea67bb6
to
83e027e
Compare
Related issue: #43865