[Mono] Turn Samples into Functional Tests

[MaximLipnin]

Related issue: #43865

The idea is to copy existing mono samples to a particular place within runtime/src/libraries/ directory and tune them to re-use library test infra like it's done for other functional tests.

As a first step, I'll try to do it with iOS sample. Any ideas on how to do it better/more correct are appreciated.

[ghost]

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

[jkotas]

• Could you please add README.md that describes what these samples are for and how to use them?
• Do we expect customers to make copy of these samples to create their own apps? Do we provide any guarantees that the sample copied this way will continue to work?
• Would https://github.com/dotnet/runtime/tree/master/src/tests be a more logical place for this?

[MaximLipnin]

@jkotas Thank you for a quick look.

• Could you please add README.md that describes what these samples are for and how to use them?

Do you mean readme for existing samples?

• Do we expect customers to make copy of these samples to create their own apps? Do we provide any guarantees that the sample copied this way will continue to work?

As far as I know those sample are used for showing off the platforms we support. Also they are useful for some debugging purposes. I don't know if the samples are supposed to be copied to create new apps.

• Would https://github.com/dotnet/runtime/tree/master/src/tests be a more logical place for this?

I mostly worked with library tests so that's why I started here. If the location you mentioned is better then I'll consider that option.

[steveisok]

@jkotas These are no longer samples. The intent is to run them through AOT/Interp/JIT to give us a good sense that a barebones app is working.

[marek-safar]

Do we expect customers to make copy of these samples to create their own apps?

No, these are specific tests which verify that MonoVM based runtime packs work as expected. I don't think CoreCLR has any such tests otherwise it'd be nice to share the logic.

Would https://github.com/dotnet/runtime/tree/master/src/tests be a more logical place for this?

Yes but apparently there is no infrastructure yet in place to support having them there.

[jkotas]

These are no longer samples. The intent is to run them through AOT/Interp/JIT to give us a good sense that a barebones app is working.

Then the directory should not be called Samples. The best name I can think of is IntegrationTests.

I do not think the name should be Mono-specific. You can imagine having e.g. ASP.NET barebone app inside this set of tests too.

[marek-safar]

This needs to check some error codes

[vargaz]

Why is there a 'tests' directory under 'IntegrationTests' ?

[MaximLipnin]

This follows the structure, which other library directories have, in order to be included in

runtime/src/libraries/tests.proj

Line 168 in 65d3e28

<ProjectReference Include="$(MSBuildThisFileDirectory)*\tests\**\*.Tests.csproj"

[MaximLipnin]

Closing it in favor of #44462