Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBOR] Make Half Read/Write methods public and add unit tests #38946

Merged
merged 2 commits into from
Jul 9, 2020
Merged

[CBOR] Make Half Read/Write methods public and add unit tests #38946

merged 2 commits into from
Jul 9, 2020

Conversation

eiriktsarpalis
Copy link
Member

Related issue: #38467

Pending API review approval. Do not merge just yet.

@eiriktsarpalis eiriktsarpalis added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-System.Security labels Jul 8, 2020
@eiriktsarpalis eiriktsarpalis added this to the 5.0.0 milestone Jul 8, 2020
@eiriktsarpalis eiriktsarpalis requested a review from bartonjs July 8, 2020 17:57
@ghost
Copy link

ghost commented Jul 8, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis mentioned this pull request Jul 8, 2020
Closed
bartonjs
bartonjs approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the ref.cs header comment.

@safern safern mentioned this pull request Jul 8, 2020
Closed
@eiriktsarpalis eiriktsarpalis merged commit a902fba into dotnet:master Jul 9, 2020
@eiriktsarpalis eiriktsarpalis deleted the cbor-half-tests branch July 9, 2020 17:10
@eiriktsarpalis eiriktsarpalis removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@bartonjs bartonjs bartonjs approved these changes

Assignees
No one assigned
Labels
area-System.Security new-api-needs-documentation
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@eiriktsarpalis @Dotnet-GitSync-Bot @stephentoub @bartonjs