Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Formats.Cbor: Add Reader and Writer methods for System.Half. #38467

Closed
eiriktsarpalis opened this issue Jun 26, 2020 · 3 comments
Closed
Assignees
Labels
api-approved API was approved in API review, it can be implemented area-System.Formats.Cbor
Milestone

Comments

@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Jun 26, 2020

Background and Motivation

The CBOR spec requires support for IEEE 754 half-precision floats. Given that we just added System.Half, we should expose reader and writer methods that handle that particular type.

Proposed API

public class CborReader
{
    public void WriteHalf(Half value);
}

public class CborWriter
{
    public Half ReadHalf();
}

Relevant implementation PR: #38946

@eiriktsarpalis eiriktsarpalis added this to the 5.0.0 milestone Jun 26, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Numerics untriaged New issue has not been triaged by the area owner labels Jun 26, 2020
@ghost
Copy link

ghost commented Jun 26, 2020

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

@ghost
Copy link

ghost commented Jun 26, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Jun 26, 2020
@bartonjs bartonjs added the api-ready-for-review API is ready for review, it is NOT ready for implementation label Jul 6, 2020
@eiriktsarpalis eiriktsarpalis self-assigned this Jul 7, 2020
@eiriktsarpalis eiriktsarpalis added the blocking Marks issues that we want to fast track in order to unblock other important work label Jul 8, 2020
@bartonjs bartonjs added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for review, it is NOT ready for implementation blocking Marks issues that we want to fast track in order to unblock other important work labels Jul 9, 2020
@bartonjs
Copy link
Member

bartonjs commented Jul 9, 2020

Approved as proposed.

public class CborReader
{
    public void WriteHalf(Half value);
}

public class CborWriter
{
    public Half ReadHalf();
}

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented area-System.Formats.Cbor
Projects
None yet
Development

No branches or pull requests

4 participants