Make linux-riscv nativeaot port robust #112736

am11 · 2025-02-20T12:53:10Z

Huge thanks to @filipnavara, all smoke tests are passing (except DwarfDump which currently doesn't account for per-architecture stats).

Contributes to #106223. We will run AOT libs tests next.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

…keThunk

…e context

…size > PAGE_SIZE

…city guarantees of RhpCheckedXchg

…ount (to be reviewed)

…tion and PROLOG_SAVE_REG_PAIR_NO_FP_INDEXED

risc-vv · 2025-02-21T07:51:11Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 5min 49s 598ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: a9a6a47a813606a208d1d860f8027475d2a18065
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 633247 / 669869 (94.53%)

=======================
      passed: 633247
      failed: 131
     skipped: 1479
      killed: 36491
------------------------
  TOTAL libs: 258
 TOTAL tests: 671348
   REAL time: 2h 45min 47s 514ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: a9a6a47a813606a208d1d860f8027475d2a18065
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 46min 10s 910ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: a9a6a47a813606a208d1d860f8027475d2a18065
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 657661 / 687860 (95.61%)

=======================
      passed: 657661
      failed: 327
     skipped: 1453
      killed: 29872
------------------------
  TOTAL libs: 258
 TOTAL tests: 689313
   REAL time: 2h 26min 38s 847ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: a9a6a47a813606a208d1d860f8027475d2a18065
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-02-21T08:01:03Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 9min 27s 369ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 7be7b764494542d81ee117b5d883573d3a7147dd
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 45min 16s 728ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 7be7b764494542d81ee117b5d883573d3a7147dd
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 626100 / 666185 (93.98%)

=======================
      passed: 626100
      failed: 142
     skipped: 1479
      killed: 39943
------------------------
  TOTAL libs: 258
 TOTAL tests: 667664
   REAL time: 2h 40min 54s 990ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 7be7b764494542d81ee117b5d883573d3a7147dd
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

src/coreclr/nativeaot/Runtime/unix/UnixNativeCodeManager.cpp

src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S

src/coreclr/nativeaot/Runtime/StackFrameIterator.cpp

src/coreclr/nativeaot/Runtime/riscv64/UniversalTransition.S

...er.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunGenericHelperNode.cs

tomeksowi · 2025-02-21T10:10:09Z

...er.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunGenericHelperNode.cs

                            encoder.EmitADDI(encoder.TargetRegister.Arg3, encoder.TargetRegister.Arg0, -NonGCStaticsNode.GetClassConstructorContextSize(factory.Target));
                            encoder.EmitLD(encoder.TargetRegister.Arg2, encoder.TargetRegister.Arg3, 0);


Suggested change

encoder.EmitADDI(encoder.TargetRegister.Arg3, encoder.TargetRegister.Arg0, -NonGCStaticsNode.GetClassConstructorContextSize(factory.Target));

encoder.EmitLD(encoder.TargetRegister.Arg2, encoder.TargetRegister.Arg3, 0);

encoder.EmitLD(encoder.TargetRegister.Arg2, encoder.TargetRegister.Arg0, -NonGCStaticsNode.GetClassConstructorContextSize(factory.Target));

ld can take the same offset, saving one instruction. The address in a3 doesn't look to be read from elsewhere.

a3 is used on line 82 (to second arg of void EmitMOV(Register regDst, Register regSrc)).

Yeah, you're right. The EmitMOV could turn into EmitADDI with the same offset, though:) Doesn't matter much either way.

am11 · 2025-02-21T10:59:56Z

I applied latest suggestions and running into sigabort. I haven't debugged it but pushed the patch to a separate branch: am11/runtime@feature/nativeaot/riscv64-port...feature/nativeaot/riscv64-port2

@tomeksowi, can we do it so in this round we focus on correctness and use follow-up PR for further optimizations? This PR is only achieving the next milestone "it passes smoke tests", it's not the final one in the series. We still have ways to go; libs testing (AOT mode), different configuration testing (e.g. release build, workstation vs. server GC etc.).

tomeksowi · 2025-02-21T11:02:05Z

@tomeksowi, can we do it so in this round we focus on correctness and use follow-up PR for further optimizations?

Agreed.

filipnavara · 2025-02-21T13:03:42Z

I applied latest suggestions and running into sigabort.

I get a crash even with the currently applied changes in this PR:

#4  0x0000002aaaea1be2 in RaiseFailFastException (arg1=0x0, arg2=0x0, arg3=1) at /home/ubuntu/runtime/src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp:97
#5  0x0000002aaae1c164 in RhpFallbackFailFast () at /home/ubuntu/runtime/src/coreclr/nativeaot/Runtime/EHHelpers.cpp:570
#6  0x0000002aab1a3cc4 in S_P_CoreLib_Internal_Runtime_CompilerHelpers_StartupCodeHelpers__CreateTypeManagers (osModule=<optimized out>, pModuleHeaders=<optimized out>, count=<optimized out>, pClasslibFunctions=<optimized out>, nClasslibFunctions=<optimized out>)
    at /home/ubuntu/runtime/src/coreclr/nativeaot/Common/src/Internal/Runtime/CompilerHelpers/StartupCodeHelpers.cs:115
Backtrace stopped: previous frame inner to this frame (corrupt stack?)

I did a full rebuild of everything to rule out any outdated binaries.

filipnavara · 2025-02-21T13:11:40Z

I probably caused that one myself, sorry. Seems like I forgot to save a file in VS Code :-/

risc-vv · 2025-02-21T13:16:09Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 10min 55s 33ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: de257a37b04ada9a8bb14aacaedb575ce85f2682
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

Co-authored-by: Tomek Sowiński <tomeksowi@gmail.com>

am11 · 2025-02-21T14:15:17Z

I probably caused that one myself, sorry. Seems like I forgot to save a file in VS Code :-/

No worries, it happened to me as well (especially when web version of VS Code saves automatically while desktop version requires Command+S 🙂).

Do you see anything additional we missed in am11/runtime@feature/nativeaot/riscv64-port...feature/nativeaot/riscv64-port2 (possibly in StackFrameIterator.cpp) which maybe causing the sigabrt?

filipnavara · 2025-02-21T14:16:53Z

Do you see anything additional we missed in am11/runtime@feature/nativeaot/riscv64-port...feature/nativeaot/riscv64-port2 (possibly in StackFrameIterator.cpp) which maybe causing the sigabrt?

Yes. #112736 (comment)

filipnavara · 2025-02-21T14:40:46Z

@am11 I pushed changes addressing all the feedback save for #112736 (comment). Tested on device.

risc-vv · 2025-02-21T14:41:00Z

2fd845a is being scheduled for building and testing

GIT: 2fd845ad9515d7e1c5d4723580b2a97eba7388f0
REPO: dotnet/runtime
BRANCH: main

risc-vv · 2025-02-21T14:56:09Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 10min 40s 100ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 627597 / 655412 (95.76%)

=======================
      passed: 627597
      failed: 328
     skipped: 1462
      killed: 27487
------------------------
  TOTAL libs: 258
 TOTAL tests: 656874
   REAL time: 2h 26min 46s 569ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 622743 / 658502 (94.57%)

=======================
      passed: 622743
      failed: 144
     skipped: 1406
      killed: 35615
------------------------
  TOTAL libs: 258
 TOTAL tests: 659908
   REAL time: 2h 40min 23s 602ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 45min 52s 616ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

am11 · 2025-02-21T15:35:23Z

Thank you! Tested after a clean build, haven't found any issue. 👍

risc-vv · 2025-02-21T20:17:01Z

0acb29d is being scheduled for building and testing

GIT: 0acb29dc604205cde6d41e60efcc1b8170764933
REPO: dotnet/runtime
BRANCH: main

Release-build FAILED

buildinfo.json
Cloning into '/godata/pipelines/Release-build/runtime'...
fatal: unable to access 'https://github.com/dotnet/runtime/': Failed to connect to github.com port 443 after 135561 ms: Couldn't connect to server

am11 and others added 30 commits February 15, 2025 22:28

Fix AOT exception handling on linux-riscv64

1048e2e

Apply more suggestions

88ce95b

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Fix unwind information for allocation helpers

59705b8

Restore correct FP registers in StackFrameIterator::UnwindFuncletInvo…

d116a11

…keThunk

Fix register addressing in GcInfoDecoder::GetRegisterSlot

b179a7f

Fix and enable software write watch

1cb6ced

Fix COOP frames layout

13953be

Fix indirections, comparison and other assembly for write barrier checks

53a4ef0

Fix cross-build on Risc-V host

c11dd62

Disable R2R in stage2 build

37680d7

Fix uninitialized value in RhpPInvoke

f861b44

Fix register in RhpPInvokeReturn

acab644

Initialize FP/RA pointers when creating StackFrameIterator from nativ…

de03a3e

…e context

Fix sign on PROLOG_SAVE_REG_PAIR_INDEXED

eb4449b

Fix more of the logic in write barriers. Needs further audit.

541ddb1

Fix incorrect unwinding information generated for methods with frame …

a0e1a83

…size > PAGE_SIZE

Fix emitting jump to bad slot helper

f48eae5

Fix unwind info for universal transitions

7734924

Fix comment

19c97fb

Fix flipped RA/FP in universal transition unwinding

c62c075

WIP: Rewrite thunk code generation

ea12bf4

WIP: Fix RhCommonStub

35a22b9

Fix layout of universal translation for unwinding

a719d7d

WIP: Add memory barriers to native AOT asm helpers (dotnet#106219)

212157a

WIP: Add fences to RhpCheckedLockCmpXchg/RhpCheckedXchg and fix atomi…

9743390

…city guarantees of RhpCheckedXchg

Preserve registers in INLINE_GET_TLS_VAR

20101ac

Preserve a7 as well

310e8f8

WIP: Attempt to fix masks in IsInProlog/TrailingEpilogueInstructionsC…

5b058e4

…ount (to be reviewed)

WIP: Fix GC hijacking flags and possible return value trashing

e5e96bb

Fix return value trashing

a5770dd

Flip the sign of PROLOG_SAVE_REG_PAIR_INDEXED to match CoreCLR defini…

a9a6a47

…tion and PROLOG_SAVE_REG_PAIR_NO_FP_INDEXED

Merge branch 'main' into feature/nativeaot/riscv64-port

7be7b76

tomeksowi reviewed Feb 21, 2025

View reviewed changes

filipnavara reviewed Feb 21, 2025

View reviewed changes

...er.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunGenericHelperNode.cs Outdated Show resolved Hide resolved

tomeksowi reviewed Feb 21, 2025

View reviewed changes

Fix the last change to sign

de257a3

filipnavara and others added 3 commits February 21, 2025 13:32

Save one mv instruction

d5adb94

Relax FENCE in R2R helpers

e34c90c

Apply suggestiosn from CR review

939c0a2

Co-authored-by: Tomek Sowiński <tomeksowi@gmail.com>

Update managed defintion of TransitionBlock too

2fd845a

Merge branch 'main' into feature/nativeaot/riscv64-port

21fc86a

am11 added 2 commits February 21, 2025 22:11

Update TLSDESC comments

84504b5

Merge branch 'main' into feature/nativeaot/riscv64-port

0acb29d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make linux-riscv nativeaot port robust #112736

Make linux-riscv nativeaot port robust #112736

am11 commented Feb 20, 2025

risc-vv commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025 •

edited

Loading

tomeksowi Feb 21, 2025

am11 Feb 21, 2025

tomeksowi Feb 21, 2025

am11 commented Feb 21, 2025

tomeksowi commented Feb 21, 2025

filipnavara commented Feb 21, 2025

filipnavara commented Feb 21, 2025

risc-vv commented Feb 21, 2025 •

edited

Loading

am11 commented Feb 21, 2025

filipnavara commented Feb 21, 2025

filipnavara commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025

risc-vv commented Feb 21, 2025 •

edited

Loading

am11 commented Feb 21, 2025

risc-vv commented Feb 21, 2025 •

edited

Loading

		encoder.EmitADDI(encoder.TargetRegister.Arg3, encoder.TargetRegister.Arg0, -NonGCStaticsNode.GetClassConstructorContextSize(factory.Target));
		encoder.EmitLD(encoder.TargetRegister.Arg2, encoder.TargetRegister.Arg3, 0);

Make linux-riscv nativeaot port robust #112736

Are you sure you want to change the base?

Make linux-riscv nativeaot port robust #112736

Conversation

am11 commented Feb 20, 2025

risc-vv commented Feb 21, 2025 • edited Loading

risc-vv commented Feb 21, 2025 • edited Loading

tomeksowi Feb 21, 2025

Choose a reason for hiding this comment

am11 Feb 21, 2025

Choose a reason for hiding this comment

tomeksowi Feb 21, 2025

Choose a reason for hiding this comment

am11 commented Feb 21, 2025

tomeksowi commented Feb 21, 2025

filipnavara commented Feb 21, 2025

filipnavara commented Feb 21, 2025

risc-vv commented Feb 21, 2025 • edited Loading

am11 commented Feb 21, 2025

filipnavara commented Feb 21, 2025

filipnavara commented Feb 21, 2025 • edited Loading

risc-vv commented Feb 21, 2025

risc-vv commented Feb 21, 2025 • edited Loading

am11 commented Feb 21, 2025

risc-vv commented Feb 21, 2025 • edited Loading

risc-vv commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025 •

edited

Loading

filipnavara commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025 •

edited

Loading