Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMB - Include GPL-3 licence text in the notice #111528

Merged
merged 1 commit into from
Jan 17, 2025
Merged

SMB - Include GPL-3 licence text in the notice #111528

merged 1 commit into from
Jan 17, 2025

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP mentioned this pull request Jan 17, 2025
Merged
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Jan 17, 2025
Open
3 tasks
@stephentoub
Copy link
Member

cc: @richlander

jkotas
jkotas approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@richlander
Copy link
Member

LGTM -- We allow GPL for tests, per https://github.com/dotnet/runtime/blob/main/docs/project/copyright.md

Non-product contributions (like tests) can be based on existing code or algorithms that are licensed with any OSI-approved license (including GPL) and should be acknowleged in a local THIRD-PARTY-NOTICE file (for example, SciMark/THIRD-PARTY-NOTICES).

@ManickaP ManickaP merged commit 4de59c4 into dotnet:main Jan 17, 2025
80 of 82 checks passed
@ManickaP ManickaP deleted the smb-licence branch January 17, 2025 14:51
grendello added a commit to grendello/runtime that referenced this pull request Jan 20, 2025
@grendello
Merge branch 'main' into dev/grendel/android-build-with-ndk
41ce72b 
* main: (89 commits)
  Add Dispose for X509Chain instance (dotnet#110740)
  Fix XML comment on regex split enumerator (dotnet#111572)
  JIT: tolerate missing InitClass map in SPMI (dotnet#111555)
  Build ilasm/ildasm packages for the host machine (dotnet#111512)
  Unicode 16.0 Support (dotnet#111469)
  Improve performance of interface method resolution in ILC (dotnet#103066)
  Fix building the host-targeting components and packing ILC (dotnet#111552)
  Improve JSON validation perf (dotnet#111332)
  Update github-merge-flow.jsonc to autoflow 9.0 to 9.0-staging (dotnet#111549)
  Include GPL-3 licence text in the notice (dotnet#111528)
  Remove explicit __compact_unwind entries from x64 assembler (dotnet#111530)
  Add MemoryExtensions overloads with comparer (dotnet#110197)
  Avoid capturing the ExecutionContext for the whole HTTP connection lifetime (dotnet#111475)
  Forward DefaultArtifactVisibility down from the VMR orchestrator (dotnet#111513)
  Fix relocs errors on riscv64 (dotnet#111317)
  Added JITDUMP_USE_ARCH_TIMESTAMP support. (dotnet#111359)
  add rcl/rcr tp and latency info (dotnet#111442)
  Fix stack overflow in compiler-generated state (dotnet#109207)
  Produce a package with the host-running ILC for repos in the VMR (dotnet#111443)
  Delete dead code in ilasm PE writer (dotnet#111218)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@pedrobsaila pedrobsaila pedrobsaila approved these changes

Assignees

@ManickaP ManickaP

Labels
area-System.Net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ManickaP @stephentoub @richlander @jkotas @pedrobsaila