Unicode 16.0 Support #111469
Merged
Unicode 16.0 Support #111469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
|
@GrabYourPitchforks @stephentoub @jkotas @matouskozak could you please help review this change? Thanks! CC @ericstj |
jkotas
approved these changes
Jan 15, 2025
stephentoub
reviewed
Jan 15, 2025
| @@ -204,14 +204,14 @@ private static void PrintValueArray<T>(string tableName, Dictionary<T, byte> d, | |||
|
|
|||
| private static void PrintByteArray(string tableName, StreamWriter file, byte[] str) | |||
| { | |||
| file.Write("\n private static ReadOnlySpan<byte> " + tableName + " => new byte[" + str.Length + "]\n {\n"); | |||
| file.Write("\n private static ReadOnlySpan<byte> " + tableName + " => // " + str.Length + "\n [\n"); | |||
There was a problem hiding this comment.
The commented length is just for readability / debuggability?
There was a problem hiding this comment.
Yes, it gives some idea about the data size too.
stephentoub
approved these changes
Jan 15, 2025
This was referenced Jan 16, 2025
Open
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
LGTM! sorry for the late review... The iossimulator test failure is unrelated and known. |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Jan 20, 2025
* main: (89 commits) Add Dispose for X509Chain instance (dotnet#110740) Fix XML comment on regex split enumerator (dotnet#111572) JIT: tolerate missing InitClass map in SPMI (dotnet#111555) Build ilasm/ildasm packages for the host machine (dotnet#111512) Unicode 16.0 Support (dotnet#111469) Improve performance of interface method resolution in ILC (dotnet#103066) Fix building the host-targeting components and packing ILC (dotnet#111552) Improve JSON validation perf (dotnet#111332) Update github-merge-flow.jsonc to autoflow 9.0 to 9.0-staging (dotnet#111549) Include GPL-3 licence text in the notice (dotnet#111528) Remove explicit __compact_unwind entries from x64 assembler (dotnet#111530) Add MemoryExtensions overloads with comparer (dotnet#110197) Avoid capturing the ExecutionContext for the whole HTTP connection lifetime (dotnet#111475) Forward DefaultArtifactVisibility down from the VMR orchestrator (dotnet#111513) Fix relocs errors on riscv64 (dotnet#111317) Added JITDUMP_USE_ARCH_TIMESTAMP support. (dotnet#111359) add rcl/rcr tp and latency info (dotnet#111442) Fix stack overflow in compiler-generated state (dotnet#109207) Produce a package with the host-running ILC for repos in the VMR (dotnet#111443) Delete dead code in ilasm PE writer (dotnet#111218) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.