Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary IDE0060 suppressions #105036

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Remove unnecessary IDE0060 suppressions #105036

merged 2 commits into from
Jul 22, 2024

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 17, 2024 •
edited
Loading

Since dotnet/roslyn#66535, IDE0060: Remove unused parameter doesn't warn for throw-only methods.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 17, 2024
@xtqqczze xtqqczze changed the title Fix unnecessary IDE0060 suppressions Remove unnecessary IDE0060 suppressions Jul 17, 2024
This was referenced Jul 17, 2024
Open
Open
@xtqqczze xtqqczze force-pushed the IDE060-AlwaysThrow branch from 0c793b5 to aea31bc Compare July 17, 2024 23:36
@xtqqczze
Fix unecessary IDE0060 suppressions
29829ba 
Since dotnet/roslyn#66535 `IDE0060` doesn't warn for throw-only methods.
@xtqqczze xtqqczze force-pushed the IDE060-AlwaysThrow branch from aea31bc to 29829ba Compare July 17, 2024 23:38
stephentoub
stephentoub approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green. Thanks.

This was referenced Jul 18, 2024
Closed
Open
Open
Open
Closed
Open
@am11 am11 added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 19, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@xtqqczze xtqqczze force-pushed the IDE060-AlwaysThrow branch from 29829ba to fa6b909 Compare July 19, 2024 20:33
This was referenced Jul 19, 2024
Open
Closed
Closed
@xtqqczze xtqqczze force-pushed the IDE060-AlwaysThrow branch from fa6b909 to 29829ba Compare July 21, 2024 21:22
@xtqqczze
Copy link
Contributor Author

@stephentoub Sorry, I force-pushed after your approval; I've reset back to 29829ba.

This was referenced Jul 22, 2024
Closed
Open
This was referenced Jul 22, 2024
Closed
Open
@stephentoub stephentoub merged commit db32911 into dotnet:main Jul 22, 2024
144 of 148 checks passed
@xtqqczze xtqqczze deleted the IDE060-AlwaysThrow branch July 22, 2024 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @stephentoub @am11