Unused parameter analyzer shouldn't warn for methods that only throw #66535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Jan 24, 2023
| await TestDiagnosticMissingAsync( | ||
| @"public class Class | ||
| { | ||
| public void Method(int [|x|]) => throw new System.Exception(); |
There was a problem hiding this comment.
Is there a test that makes sure it still reports if there's more than just a throw?
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CodeStyle; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using Microsoft.CodeAnalysis.FlowAnalysis.SymbolUsageAnalysis; | ||
| using Microsoft.CodeAnalysis.LanguageService; |
Youssef1313
reviewed
Jan 24, 2023
...s/RemoveUnusedParametersAndValues/CSharpRemoveUnusedParametersAndValuesDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
suggested changes
Jan 24, 2023
There was a problem hiding this comment.
Can we have a test like:
public class C
{
public C() => throw new System.Exception();
}I'm expecting the cast to fail in C# implementation. It should probably be BaseMethodDeclarationSyntax, but even then, I'm not sure if it can fail. Similar thing to VB, though it won't crash due to TryCast usage, but could lead to unintended behavior.
It looks like the analyzer currently doesn't support local functions, but it would be good to add a test to make sure things still work properly if local functions are supported in future.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 17, 2024
Since dotnet/roslyn#66535 `IDE0060` doesn't warn for throw-only methods.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 17, 2024
Since dotnet/roslyn#66535 `IDE0060` doesn't warn for throw-only methods.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 17, 2024
Since dotnet/roslyn#66535 `IDE0060` doesn't warn for throw-only methods.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 19, 2024
Since dotnet/roslyn#66535 `IDE0060` doesn't warn for throw-only methods.
stephentoub
pushed a commit
to dotnet/runtime
that referenced
this pull request
Jul 22, 2024
Since dotnet/roslyn#66535 `IDE0060` doesn't warn for throw-only methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65275