Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IF_SVE_FZ_2A and IF_SVE_HG_2A consistent with similar groups #100089

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Make IF_SVE_FZ_2A and IF_SVE_HG_2A consistent with similar groups #100089

merged 1 commit into from
Mar 22, 2024

Conversation

snickolls-arm
Copy link
Contributor

This makes the FZ_2A and HG_2A groups that take source registers in the form {Zn1 - Zn2} take in an even numbered register as Zn1 and set Zn2 = Zn1 +1. This makes it consistent with some other groups of this form, for these groups I have also added assertions that Zn1 is even where necessary.

@snickolls-arm
Make the source encoding for groups IF_SVE_FZ_2A and IF_SVE_HG_2A con…
2d6c1d5 
…sistent with other groups with similar operands
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 21, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 21, 2024
@snickolls-arm
Copy link
Contributor Author

@a74nh @kunalspathak @dotnet/arm64-contrib @TIHan

@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Mar 21, 2024
kunalspathak
kunalspathak approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, it seems like IF_SVE_GA_2A was inconsistent in the displaying the instruction and didn't need fix up that was done for IF_SVE_FZ_2A and IF_SVE_HG_2A.

@kunalspathak
Copy link
Member

cc: @TIHan

@build-analysis build-analysis bot mentioned this pull request Mar 21, 2024
Closed
@kunalspathak
Copy link
Member

/ba-g The failure is caused by #100047 and is fixed in #100066

@kunalspathak kunalspathak merged commit c68c2e6 into dotnet:main Mar 22, 2024
107 of 110 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@snickolls-arm snickolls-arm deleted the github-FZ,HG_2A_fix branch January 17, 2025 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snickolls-arm @kunalspathak