Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording so to pass Accessibility Insights #64418

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Oct 1, 2022

Fixes AB#1522628

Since options are put into a list, they cannot have the same wording and control type as siblings. This seemed like the easiest fix to give context for sight impaired users without restructuring the options page entirely.

@ryzngard ryzngard requested a review from a team as a code owner October 1, 2022 00:26
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Also wouldn't be opposed to "Insert space between declared method name and its opening parenthesis" just to make it even clearer

@ryzngard ryzngard merged commit a70d888 into dotnet:main Oct 26, 2022
@ryzngard ryzngard deleted the a11y_spacing_options branch October 26, 2022 20:09
@ghost ghost added this to the Next milestone Oct 26, 2022
@allisonchou allisonchou modified the milestones: Next, 17.5 P2 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants