Revert "Implement IAttributeOperation (#59369)" #63485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d89769b.
This was referenced Aug 19, 2022
|
@333fred The roslyn-analyzers PR was merged. When can this revert be reverted back again? |
|
When we update VS. |
|
I'm still working on getting the VS build using the new analyzers. I would expect the IAttributeOperation won't be added back in until 17.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d89769b.
This breaks VS build in a fair number of places. @333fred is tracking some fixes here dotnet/roslyn-analyzers#6114 but there are too many places popping up now to attempt to suppress the warnings. The original PR can be taken when we are able to update the copy of roslyn analyzers used by the VS build and have done a val build on that update + Roslyn.
This PR in VS is as far as I got with suppressions - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/418436, but still has many errors.