Do not warn on zero-length allocations in unspecified params parameters in attributes #6114
Conversation
…rs in attributes Fixes an issue introduced with dotnet/roslyn#59369, as the AvoidZeroLengthAllocations analyzer did not see these params parameters before.
| { | ||
| IArrayCreationOperation arrayCreationExpression = (IArrayCreationOperation)context.Operation; | ||
|
|
||
| // We can't replace array allocations in attributes, as they're persisted to metadata | ||
| // TODO: Once we have operation walkers, we can replace this syntactic check with an operation-based check. | ||
| if (arrayCreationExpression.Syntax.Ancestors().Any(isAttributeSytnax)) | ||
| if (arrayCreationExpression.Syntax.AncestorsAndSelf().Any(isAttributeSyntax)) |
There was a problem hiding this comment.
params parameters have the attribute itself as their syntax.
Note: we could potentially check for an IAttributeOperation itself, but I'm not familiar with the process for updating the reference used by the analyzer itself so it would know about that type.
There was a problem hiding this comment.
Note: we could potentially check for an IAttributeOperation itself, but I'm not familiar with the process for updating the reference used by the analyzer itself so it would know about that type.
In case you wanted to go this route, new operations goes into Lightup layer, e.g:
We can't yet update the product code to consume latest Roslyn versions.
Then, to consume a Roslyn version in tests that have IAttributeOperation, we update the following:
roslyn-analyzers/eng/Versions.props
Line 48 in 793113a
There was a problem hiding this comment.
We would have to leave this check in the code anyway, so I don't think it's worth it.
There was a problem hiding this comment.
params parameters have the attribute itself as their syntax.
Just out of curiosity is that all params parameters or just ones that are zero-length like this?
There was a problem hiding this comment.
Just the implicit ones. It matches the behavior for use in non-attribute locations (ie, just a regular invocation).
| { | ||
| IArrayCreationOperation arrayCreationExpression = (IArrayCreationOperation)context.Operation; | ||
|
|
||
| // We can't replace array allocations in attributes, as they're persisted to metadata | ||
| // TODO: Once we have operation walkers, we can replace this syntactic check with an operation-based check. | ||
| if (arrayCreationExpression.Syntax.Ancestors().Any(isAttributeSytnax)) | ||
| if (arrayCreationExpression.Syntax.AncestorsAndSelf().Any(isAttributeSyntax)) |
There was a problem hiding this comment.
params parameters have the attribute itself as their syntax.
Just out of curiosity is that all params parameters or just ones that are zero-length like this?
|
@mavasani can you please take a look at the code metrics failures? A quick look told me they were a bit more complicated than fixing up in a minute or two :). |
...rs/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/ImplementIDisposableCorrectly.cs
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6114 +/- ##
==========================================
- Coverage 96.05% 96.02% -0.03%
==========================================
Files 1343 1343
Lines 309713 309474 -239
Branches 9956 9950 -6
==========================================
- Hits 297490 297181 -309
- Misses 9822 9894 +72
+ Partials 2401 2399 -2 |
Fixes an issue introduced with dotnet/roslyn#59369, as the AvoidZeroLengthAllocations analyzer did not see these params parameters before.