CA1311 VB - short-circuiting or #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6016 +/- ##
==========================================
- Coverage 96.03% 96.03% -0.01%
==========================================
Files 1338 1338
Lines 307108 307108
Branches 9785 9785
==========================================
- Hits 294922 294918 -4
- Misses 9811 9813 +2
- Partials 2375 2377 +2 |
Evangelink
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the
IsKindextension method is implemented in a null-tolerant way, it is still better to not check the right hand side of the or expression when it's not necessary, hence this PR.@buyaa-n this is a follow-up of this - #6010