CA1311 various fixes #6010
Merged
CA1311 various fixes #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
May 24, 2022
Comment on lines
+18
to
+21
| Dim invocation = DirectCast(node, InvocationExpressionSyntax) | ||
| If invocation.Expression.IsKind(SyntaxKind.SimpleMemberAccessExpression) Then | ||
| Return DirectCast(invocation.Expression, MemberAccessExpressionSyntax).Name.GetLocation() | ||
| End If |
There was a problem hiding this comment.
Suggested change
| Dim invocation = DirectCast(node, InvocationExpressionSyntax) | |
| If invocation.Expression.IsKind(SyntaxKind.SimpleMemberAccessExpression) Then | |
| Return DirectCast(invocation.Expression, MemberAccessExpressionSyntax).Name.GetLocation() | |
| End If | |
| node = DirectCast(node, InvocationExpressionSyntax).Expression |
There was a problem hiding this comment.
Not sure why @Youssef1313 suggested this
Youssef1313
reviewed
May 24, 2022
...s/VisualBasic/Microsoft.NetCore.Analyzers/Runtime/BasicSpecifyCultureForToLowerAndToUpper.vb
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #6010 +/- ##
========================================
Coverage 96.03% 96.03%
========================================
Files 1330 1330
Lines 306571 306672 +101
Branches 9722 9729 +7
========================================
+ Hits 294426 294527 +101
+ Misses 9796 9792 -4
- Partials 2349 2353 +4 |
buyaa-n
reviewed
May 25, 2022
...alBasic/Microsoft.NetCore.Analyzers/Runtime/BasicSpecifyCultureForToLowerAndToUpper.Fixer.vb
Show resolved
Hide resolved
…me/BasicSpecifyCultureForToLowerAndToUpper.vb Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
buyaa-n
approved these changes
May 26, 2022
There was a problem hiding this comment.
LGTM, thanks for the fix @TKharaishvili and thanks for pointing it out @Youssef1313
TKharaishvili
commented
May 27, 2022
...alBasic/Microsoft.NetCore.Analyzers/Runtime/BasicSpecifyCultureForToLowerAndToUpper.Fixer.vb
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of these two - #5970 #2186
@buyaa-n @Youssef1313 Here's the new PR addressing the issues left over from the previous ones.
I've updated the fixer to address the VB edge case and I've also fixed the typo in the resource files.
I haven't however moved unit tests into a single file. Is that a must? I see that many analyzers/fixers in the codebase have separate files for unit tests.