-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to release/6.0.1xx-preview1 #4527
Merged
mavasani
merged 72 commits into
release/6.0.1xx-preview1
from
merges/master-to-release/6.0.1xx-preview1
Dec 16, 2020
Merged
Merge master to release/6.0.1xx-preview1 #4527
mavasani
merged 72 commits into
release/6.0.1xx-preview1
from
merges/master-to-release/6.0.1xx-preview1
Dec 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ASP.NET MVC Controller property setter parameters as tainted
Also moves Humanizer based EnumsShouldHavePluralNamesAnalyzer which only shipped in FxCopAnalyzers package into Text.Analyzers project.
# Conflicts: # docs/Analyzer Configuration.md
CA1068: allow excluded_symbol_names user option
Remove FxCopAnalyzers.sln and related projects from the repo
…AndConfigFiles.csproj Now we have single post-build utility tool 'GenerateDocumentationAndConfigFiles' for generating all of the following files: 1. Documentation files (md and sarif files + file listing rules missing documentation) 2. Config files (global configs for AnalysisLevel and AnalysisMode + editorconfig/ruleset files) 3. props and targets files shipping with the packages
Find tainted data parameter SyntaxNodes more robustly, and don't treat ASP.NET MVC Controller property setter parameters as tainted
Merge 2.9.x to master
Merge GenerateGlobalAnalyzerConfigs.csproj into GenerateDocumentation…
Co-authored-by: Manish Vasani <mavasani@microsoft.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
…130.4 (#4560) [release/5.0.1xx] Update dependencies from dotnet/arcade
Fix nullability for SymbolNamesWithValueOption
…130.4 (#4561) [release/5.0.2xx] Update dependencies from dotnet/arcade
Update the compiler to the 3.8.0 release
Couple of fixes for CA1508
…e/5.0.2xx Merge release/5.0.1xx to release/5.0.2xx
Merge release/5.0.2xx to master
Merge release/5.0.2xx to master
Add support for category-specific AnalysisLevel properties
Fix CA2119 to report only on correct interface members
The description of this descriptor was incorrect and although there is room for improvement in the rule we are technically not capable at the moment to do such detection.
Fix CA1802 to not report on nint and nuint
Remove second descriptor because of FP rate
…release/6.0.1xx-preview1
mavasani
approved these changes
Dec 16, 2020
Codecov Report
@@ Coverage Diff @@
## release/6.0.1xx-preview1 #4527 +/- ##
============================================================
+ Coverage 95.78% 95.82% +0.03%
============================================================
Files 1164 1169 +5
Lines 264459 266085 +1626
Branches 15979 16089 +110
============================================================
+ Hits 253324 254986 +1662
+ Misses 9097 9033 -64
- Partials 2038 2066 +28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into release/6.0.1xx-preview1.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout merges/master-to-release/6.0.1xx-preview1 git reset --hard upstream/release/6.0.1xx-preview1 git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-release/6.0.1xx-preview1 --force