Add support for category-specific AnalysisLevel properties #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements category specific AnalysisLevel properties as per dotnet/roslyn#49250 (comment). Users would now be able to specify the core AnalysisLevel and override category specific AnalysisLevel for each category. ```xml <AnalysisLevel>5-minimum</AnalysisLevel> <AnalysisLevelSecurity>latest-all</ AnalysisLevelSecurity > <AnalysisLevelPerformance>preview-recommended</AnalysisLevelPerformance> <AnalysisLevelGlobalization>5-none</AnalysisLevelGlobalization> ``` 1. The post-build tool now generates category-specific global configs for each supported analysis mode 2. The tool also generates category-specific `AddGlobalAnalyzerConfigForPackage` targets so that if user overrides a category-specific AnalysisLevel property NOTE: This PR depends on feature dotnet/roslyn#48634, which is currently in code review: dotnet/roslyn#49834
|
Also tagging @chsienki as an FYI. This analyzer configuration feature for .NET 6 relies on Chris' PR dotnet/roslyn#49834 to support precedence levels for global configs. |
Codecov Report
@@ Coverage Diff @@
## master #4556 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 1177 1177
Lines 268158 268257 +99
Branches 16192 16202 +10
==========================================
+ Hits 257009 257100 +91
- Misses 9070 9090 +20
+ Partials 2079 2067 -12 |
mavasani
commented
Dec 11, 2020
jmarolf
approved these changes
Dec 13, 2020
|
Thanks @jmarolf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements category specific AnalysisLevel properties as per dotnet/roslyn#49250 (comment).
Users would now be able to specify the core AnalysisLevel and override category specific AnalysisLevel for each category.
AddGlobalAnalyzerConfigForPackagetargets so that if user overrides a category-specific AnalysisLevel property, we pass in both the configsglobal_levelproperty as per the feature Global analyzer config precedence roslyn#48634, which is currently in code review: Support global analyzer config levels: roslyn#49834Testing
Verified that setting the above matrix of category-agnostic and category-specific AnalysisLevel property leads to correct global config files being passed to the compiler. Currently, we get warnings about conflicting entries for same diagnostic ID in different config files, but that would be resolved with dotnet/roslyn#49834