[Java.Interop] JniType.RegisterNativeMethods() is public #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#1027
Context: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2048/
Commit 7d51163 changed the visibility of
JniType.RegisterNativeMethods()
frompublic
tointernal
, in aneffort to reduce the likelihood of "user error" from calling
JNIEnv::RegisterNatives()
multiple times, asJNIEnv::RegisterNatives()
invocations are replacements, not"additive"; calling it more than once is generally Wrong™.
Unfortunately,
JniType.RegisterNativeMethods()
is part of thepublic and shipping API, so we can't remove it, as seen in the
xamarin-android PR build output:
Revert the visibility of
JniType.RegisterNativeMethods()
topublic
, so that we don't break API compatibility.