Bump to Java.Interop/master/1bcfcc5 #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanpeppers, |
jonpryor
added a commit
to jonpryor/java.interop
that referenced
this pull request
Nov 15, 2017
Context: dotnet/android#1027 Context: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2048/ Commit 7d51163 changed the visibility of `JniType.RegisterNativeMethods()` from `public` to `internal`, in an effort to reduce the likelihood of "user error" from calling `JNIEnv::RegisterNatives()` multiple times, as `JNIEnv::RegisterNatives()` invocations are *replacements*, not "additive"; calling it more than once is *generally* Wrong™. *Unfortunately*, `JniType.RegisterNativeMethods()` is part of the public and shipping API, so we can't remove it, as seen in the [xamarin-android PR build][pr2048] output: [pr2048]: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2048/consoleText ABI BREAK IN: Java.Interop.dll <!-- start namespace Java.Interop --> <div> <h2>Namespace Java.Interop</h2> <!-- start type JniType --> <div> <h3>Type Changed: Java.Interop.JniType</h3> <p>Removed method:</p> <pre> <span class='removed removed-method breaking' data-is-breaking>public void RegisterNativeMethods (JniNativeMethodRegistration[]);</span> </pre> Revert the visibility of `JniType.RegisterNativeMethods()` to `public`, so that we don't break API compatibility.
jonpryor
added a commit
to dotnet/java-interop
that referenced
this pull request
Nov 15, 2017
Context: dotnet/android#1027 Context: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2048/ Commit 7d51163 changed the visibility of `JniType.RegisterNativeMethods()` from `public` to `internal`, in an effort to reduce the likelihood of "user error" from calling `JNIEnv::RegisterNatives()` multiple times, as `JNIEnv::RegisterNatives()` invocations are *replacements*, not "additive"; calling it more than once is *generally* Wrong™. *Unfortunately*, `JniType.RegisterNativeMethods()` is part of the public and shipping API, so we can't remove it, as seen in the [xamarin-android PR build][pr2048] output: [pr2048]: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2048/consoleText ABI BREAK IN: Java.Interop.dll <!-- start namespace Java.Interop --> <div> <h2>Namespace Java.Interop</h2> <!-- start type JniType --> <div> <h3>Type Changed: Java.Interop.JniType</h3> <p>Removed method:</p> <pre> <span class='removed removed-method breaking' data-is-breaking>public void RegisterNativeMethods (JniNativeMethodRegistration[]);</span> </pre> Revert the visibility of `JniType.RegisterNativeMethods()` to `public`, so that we don't break API compatibility.
Context: dotnet/java-interop#211 Looking to fix `ANDROID_SDK_PATH` not set in tests on Windows.
235922e to
6c27be6
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#211
Looking to fix
ANDROID_SDK_PATHnot set in tests on Windows.