Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty ItemsToSign when building VisualFSharp with core msbuild #18109

Closed
wants to merge 1 commit into from

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Dec 5, 2024

Needed for dotnet/sdk#44855

VisualFSharp.sln only produces artifacts files when built with full framework MSBuild, so we need to allow empty sign list when building VisualFSharp.sln with Core MSBuild in order to pass -sign.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ No release notes required

@ellahathaway ellahathaway marked this pull request as ready for review December 5, 2024 23:08
@ellahathaway ellahathaway requested a review from a team as a code owner December 5, 2024 23:08
@T-Gro T-Gro enabled auto-merge (squash) December 6, 2024 08:10
@ViktorHofer ViktorHofer disabled auto-merge December 6, 2024 08:42
@ViktorHofer
Copy link
Member

Let's wait with merging this until we figured out why artifacts don't get created.

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for the above reasons to prevent accidental merge.

@ellahathaway
Copy link
Member Author

Let's wait with merging this until we figured out why artifacts don't get created.

I think the lack of artifacts is expected here. VisualFSharp.sln only produces artifacts on full msbuild. Alternatively, it looks like Microsoft.FSharp.Compiler.sln is producing the correct artifacts (albeit not all of them are shipping/aligned with linux). See dotnet/sdk#44855 (comment)

@ellahathaway
Copy link
Member Author

I'm closing this PR in favor of opening an issue against fsharp. In the case where we're building on windows, -noVisualStudio is not passed, -sign is passed, and we're building with .NET Core MSBuild, the build fails. The correct thing to do here would be to avoid passing -sign to the build in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants