Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty ItemsToSign when building VisualFSharp with core msbuild #18109

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eng/Signing.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
<Project>

<!--
VisualFSharp.sln only produces artifacts files when built with full framework MSBuild,
so we need to allow empty sign list when building VisualFSharp.sln with Core MSBuild.
-->
<PropertyGroup Condition="'$(MSBuildRuntimeType)' == 'Core' and $(Projects.Contains('VisualFSharp.sln'))">
<AllowEmptySignList>true</AllowEmptySignList>
</PropertyGroup>

<ItemGroup>
<FileSignInfo Include="Nerdbank.Streams.dll" CertificateName="None" />
<FileSignInfo Include="Newtonsoft.Json.dll" CertificateName="None" />
Expand Down
Loading