Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Fix failure on Unix associate with converting PDBs #1764

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Fix failure on Unix associate with converting PDBs #1764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b4961
Fix failure on Unix associate with convering PDBs
vancem Oct 26, 2017
36254ce
Fixed missing quotes
vancem Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,15 @@
</PropertyGroup>
</Target>

<Target Name="GenerateWindowsPdbsForAssemblyBeingTested" BeforeTargets="GenerateTestExecutionScripts">
<!-- *********************************************************************************************** -->
<!-- As of 10/2017 OpenCover does not support portable PDBs, but we want the builds to generate
portable PDBs. Thus we generate windows PDBs from portable PDBs here. Can be removed
when OpenCover directly supports Portable PDBs (probably by early 2018) -->

<Target Name="GenerateWindowsPdbsForAssemblyBeingTested"
BeforeTargets="GenerateTestExecutionScripts"
Condition="'$(CodeCoverageEnabled)' == 'true' and '$(TargetOS)'=='Windows_NT'">

<!-- We look for the DLL being tested for coverage and its PDB create a WindowsPDB\*.pdb which has
the windows PDB. -->
<ItemGroup>
Expand All @@ -80,8 +84,8 @@
portable PDBs directly -->
<Message Importance="high" Text="Replacing Portable PDB with Windows Pdb in place!" />
<Copy SourceFiles="%(ExistingPortableDllsToConvert.TargetPath)" DestinationFolder="$(NETCoreAppTestSharedFrameworkPath)" Condition="Exists('%(ExistingPortableDllsToConvert.TargetPath)')"/>

</Target>
<!-- *********************************************************************************************** -->

<!-- xUnit command line with coverage enabled -->
<PropertyGroup Condition="'$(CoverageEnabledForProject)'=='true'">
Expand Down