This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Fix failure on Unix associate with converting PDBs #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code to convert portable pdbs to windows pdbs was being run on UNIX machines. This is clearly not needed and was causing failures. Fix it to only run on non Windows and only for coverage (which is the only thing we know that needs the Windows PDBs). See https://github.com/dotnet/corefx/issues/24807.
|
@vancem, |
|
This is to fix bug https://github.com/dotnet/corefx/issues/24807 |
dagood
approved these changes
Oct 26, 2017
| <!-- As of 10/2017 OpenCover does not support portable PDBs, but we want the builds to generate | ||
| portable PDBs. Thus we generate windows PDBs from portable PDBs here. Can be removed | ||
| when OpenCover directly supports Portable PDBs (probably by early 2018) --> | ||
|
|
||
| <Target Name="GenerateWindowsPdbsForAssemblyBeingTested" BeforeTargets="GenerateTestExecutionScripts" | ||
| Condition="$(CodeCoverageEnabled) == 'true' and '$(TargetOS)'=='Windows_NT'"> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <!-- As of 10/2017 OpenCover does not support portable PDBs, but we want the builds to generate | ||
| portable PDBs. Thus we generate windows PDBs from portable PDBs here. Can be removed | ||
| when OpenCover directly supports Portable PDBs (probably by early 2018) --> | ||
|
|
||
| <Target Name="GenerateWindowsPdbsForAssemblyBeingTested" BeforeTargets="GenerateTestExecutionScripts" | ||
| Condition="$(CodeCoverageEnabled) == 'true' and '$(TargetOS)'=='Windows_NT'"> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dotnet-bot test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to convert portable pdbs to windows pdbs was being run on UNIX machines.
This is clearly not needed and was causing failures. Fix it to only run on non Windows
and only for coverage (which is the only thing we know that needs the Windows PDBs).
Basically just make the conversion condition stricter.
See also https://github.com/dotnet/corefx/issues/24807.