Fix compilation with latest roslyn

src/Components/Server/test/Circuits/ServerComponentDeserializerTest.cs

@@ -156,7 +156,7 @@ public void CanParseMultipleMarkersWithAndWithoutParameters()
     public void DoesNotParseOutOfOrderMarkers()
     {
         // Arrange
-        var markers = SerializeMarkers(CreateMarkers(typeof(TestComponent), typeof(TestComponent)).Reverse().ToArray());
+        var markers = SerializeMarkers(Enumerable.Reverse(CreateMarkers(typeof(TestComponent), typeof(TestComponent))).ToArray());
         var serverComponentDeserializer = CreateServerComponentDeserializer();
 
         // Act & assert

src/DataProtection/DataProtection/src/Internal/ContainerUtils.cs

@@ -103,7 +103,7 @@ private static bool IsProcessRunningInContainer()
 
         var lines = File.ReadAllLines(procFile);
         // typically the last line in the file is "1:name=openrc:/docker"
-        return lines.Reverse().Any(l => l.EndsWith("name=openrc:/docker", StringComparison.Ordinal));
+        return Enumerable.Reverse(lines).Any(l => l.EndsWith("name=openrc:/docker", StringComparison.Ordinal));
     }
 
     private static bool GetBooleanEnvVar(string envVarName)

src/Framework/App.Runtime/src/CompatibilitySuppressions.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
+<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
 <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
   <Suppression>
     <DiagnosticId>PKV0001</DiagnosticId>

src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteEmbeddedLanguage/Infrastructure/SyntaxNodeExtensions.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
+using System.Linq;
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
@@ -126,7 +127,7 @@ private static SyntaxToken GetInitialToken(
     /// </summary>
     private static SyntaxToken FindSkippedTokenBackward(SyntaxTriviaList triviaList, int position)
     {
-        foreach (var trivia in triviaList.Reverse())
+        foreach (var trivia in Enumerable.Reverse(triviaList))
         {
             if (trivia.HasStructure)
             {

src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DetectMisplacedLambdaAttribute.cs

@@ -70,7 +70,7 @@ static bool IsInValidNamespace(INamespaceSymbol? @namespace)
 
         static IMethodSymbol? GetReturnedInvocation(IBlockOperation blockOperation)
         {
-            foreach (var op in blockOperation.ChildOperations.Reverse())
+            foreach (var op in Enumerable.Reverse(blockOperation.ChildOperations))
             {
                 if (op is IReturnOperation returnStatement)
                 {

src/Grpc/JsonTranscoding/src/Shared/Server/MethodOptions.cs

@@ -116,7 +116,7 @@ public static MethodOptions Create(IEnumerable<GrpcServiceOptions> serviceOption
         string? responseCompressionAlgorithm = null;
         CompressionLevel? responseCompressionLevel = null;
 
-        foreach (var options in serviceOptions.Reverse())
+        foreach (var options in Enumerable.Reverse(serviceOptions))
         {
             AddCompressionProviders(resolvedCompressionProviders, options.CompressionProviders);
             tempInterceptors.InsertRange(0, options.Interceptors);

src/Hosting/Hosting/src/GenericHost/GenericWebHostService.cs

@@ -132,7 +132,7 @@ static string ExpandPorts(string ports, string scheme)
 
             var builder = ApplicationBuilderFactory.CreateBuilder(Server.Features);
 
-            foreach (var filter in StartupFilters.Reverse())
+            foreach (var filter in Enumerable.Reverse(StartupFilters))
             {
                 configure = filter.Configure(configure);
             }

src/Hosting/Hosting/src/Internal/StartupLoader.cs

@@ -222,7 +222,7 @@ void RunPipeline(TContainerBuilder containerBuilder)
 #pragma warning restore CS0612 // Type or member is obsolete
 
                 Action<TContainerBuilder> pipeline = InvokeConfigureContainer;
-                foreach (var filter in filters.Reverse())
+                foreach (var filter in Enumerable.Reverse(filters))
                 {
                     pipeline = filter.ConfigureContainer(pipeline);
                 }

src/Hosting/Hosting/src/Internal/WebHost.cs

@@ -214,7 +214,7 @@ private RequestDelegate BuildApplication()
             Action<IApplicationBuilder> configure = _startup!.Configure;
             if (startupFilters != null)
             {
-                foreach (var filter in startupFilters.Reverse())
+                foreach (var filter in Enumerable.Reverse(startupFilters))
                 {
                     configure = filter.Configure(configure);
                 }

src/Http/Routing/test/UnitTests/Tree/TreeRouterTest.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Globalization;
+using System.Linq;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing.Constraints;
 using Microsoft.AspNetCore.Routing.Template;
@@ -100,7 +101,7 @@ public async Task TreeRouter_RouteAsync_MatchesRouteWithTheRightLength(string ur
 
         // We setup the route entries in reverse order of precedence to ensure that when we
         // try to route the request, the route with a higher precedence gets tried first.
-        foreach (var template in routes.Reverse())
+        foreach (var template in Enumerable.Reverse(routes))
         {
             MapInboundEntry(builder, template);
         }
@@ -147,7 +148,7 @@ public async Task TreeRouter_RouteAsync_MatchesRoutesWithDefaults(string url, ob
 
         // We setup the route entries in reverse order of precedence to ensure that when we
         // try to route the request, the route with a higher precedence gets tried first.
-        foreach (var template in routes.Reverse())
+        foreach (var template in Enumerable.Reverse(routes))
         {
             MapInboundEntry(builder, template);
         }
@@ -199,7 +200,7 @@ public async Task TreeRouter_RouteAsync_MatchesConstrainedRoutesWithDefaults(str
 
         // We setup the route entries in reverse order of precedence to ensure that when we
         // try to route the request, the route with a higher precedence gets tried first.
-        foreach (var template in routes.Reverse())
+        foreach (var template in Enumerable.Reverse(routes))
         {
             MapInboundEntry(builder, template);
         }
@@ -242,7 +243,7 @@ public async Task TreeRouter_RouteAsync_MatchesCatchAllRoutesWithDefaults()
 
         // We setup the route entries in reverse order of precedence to ensure that when we
         // try to route the request, the route with a higher precedence gets tried first.
-        foreach (var template in routes.Reverse())
+        foreach (var template in Enumerable.Reverse(routes))
         {
             MapInboundEntry(builder, template);
         }
@@ -340,7 +341,7 @@ public async Task TreeRouter_RouteAsync_DoesNotMatchShorterUrl()
 
         // We setup the route entries in reverse order of precedence to ensure that when we
         // try to route the request, the route with a higher precedence gets tried first.
-        foreach (var template in routes.Reverse())
+        foreach (var template in Enumerable.Reverse(routes))
         {
             MapInboundEntry(builder, template);
         }

src/Http/WebUtilities/test/FileBufferingReadStreamTests.cs

@@ -488,7 +488,7 @@ public async Task CopyToAsyncWorksWithFileThreshold()
         // 4K is the lower bound on buffer sizes
         var bufferSize = 4096;
         var mostExpectedWrites = 8;
-        var data = Enumerable.Range(0, bufferSize * mostExpectedWrites).Select(b => (byte)b).Reverse().ToArray();
+        var data = Enumerable.Reverse(Enumerable.Range(0, bufferSize * mostExpectedWrites).Select(b => (byte)b)).ToArray();
         var inner = new MemoryStream(data);
 
         using var stream = new FileBufferingReadStream(inner, 100, bufferLimit: null, GetCurrentDirectory());

src/Middleware/Diagnostics/src/DeveloperExceptionPage/DeveloperExceptionPageMiddlewareImpl.cs

@@ -67,7 +67,7 @@ public DeveloperExceptionPageMiddlewareImpl(
         _exceptionHandler = DisplayException;
         _serializationContext = CreateSerializationContext(jsonOptions?.Value);
         _problemDetailsService = problemDetailsService;
-        foreach (var filter in filters.Reverse())
+        foreach (var filter in Enumerable.Reverse(filters))
         {
             var nextFilter = _exceptionHandler;
             _exceptionHandler = errorContext => filter.HandleExceptionAsync(errorContext, nextFilter);
@@ -228,8 +228,8 @@ private async Task DisplayExceptionContent(ErrorContext errorContext)
         if (_problemDetailsService == null || !await _problemDetailsService.TryWriteAsync(new()
             {
                 HttpContext = httpContext,
-                ProblemDetails = CreateProblemDetails(errorContext, httpContext), 
-                Exception = errorContext.Exception 
+                ProblemDetails = CreateProblemDetails(errorContext, httpContext),
+                Exception = errorContext.Exception
             }))
         {
             httpContext.Response.ContentType = "text/plain; charset=utf-8";

src/OpenApi/src/Extensions/JsonNodeSchemaExtensions.cs

@@ -196,7 +196,7 @@ internal static void ApplyRouteConstraints(this JsonNode schema, IEnumerable<IRo
     {
         // Apply constraints in reverse order because when it comes to the routing
         // layer the first constraint that is violated causes routing to short circuit.
-        foreach (var constraint in constraints.Reverse())
+        foreach (var constraint in Enumerable.Reverse(constraints))
         {
             if (constraint is MinRouteConstraint minRouteConstraint)
             {

src/Servers/Connections.Abstractions/src/ConnectionBuilder.cs

@@ -42,7 +42,7 @@ public ConnectionDelegate Build()
             return Task.CompletedTask;
         };
 
-        foreach (var component in _components.Reverse())
+        foreach (var component in Enumerable.Reverse(_components))
         {
             app = component(app);
         }

src/Servers/Connections.Abstractions/src/MultiplexedConnectionBuilder.cs

@@ -42,7 +42,7 @@ public MultiplexedConnectionDelegate Build()
             return Task.CompletedTask;
         };
 
-        foreach (var component in _components.Reverse())
+        foreach (var component in Enumerable.Reverse(_components))
         {
             app = component(app);
         }

src/Servers/Kestrel/Core/src/Internal/KestrelServerImpl.cs

@@ -54,8 +54,8 @@ internal KestrelServerImpl(
     {
         ArgumentNullException.ThrowIfNull(transportFactories);
 
-        _transportFactories = transportFactories.Reverse().ToList();
-        _multiplexedTransportFactories = multiplexedFactories.Reverse().ToList();
+        _transportFactories = Enumerable.Reverse(transportFactories).ToList();
+        _multiplexedTransportFactories = Enumerable.Reverse(multiplexedFactories).ToList();
         _httpsConfigurationService = httpsConfigurationService;
 
         if (_transportFactories.Count == 0 && _multiplexedTransportFactories.Count == 0)

src/Testing/src/xunit/DockerOnlyAttribute.cs

@@ -31,7 +31,7 @@ public bool IsMet
 
             var lines = File.ReadAllLines(procFile);
             // typically the last line in the file is "1:name=openrc:/docker"
-            return lines.Reverse().Any(l => l.EndsWith("name=openrc:/docker", StringComparison.Ordinal));
+            return Enumerable.Reverse(lines).Any(l => l.EndsWith("name=openrc:/docker", StringComparison.Ordinal));
         }
     }
 }