Fix compilation with latest roslyn

[am11]

Related PR in runtime: dotnet/runtime#109467

To unblock dotnet/sdk#43015, errors like these:

/vmr/src/aspnetcore/src/DataProtection/DataProtection/src/Internal/ContainerUtils.cs(106,31): error CS0023: Operator '.' cannot be applied to operand of type 'void' [/vmr/src/aspnetcore/src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj::TargetFramework=netstandard2.0]

[am11]

@ViktorHofer, I wasn't able to update packages to 4.13.0-1.24510.9 because it's failing with [DiagnosticAnalyzer(LanguageNames.CSharp)]:

/workspaces/aspnetcore/src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/RouteHandlerAnalyzer.cs(18,2): error RS1038: This compiler extension should not be implemented in an assembly containing a reference to Microsoft.CodeAnalysis.Workspaces. The Microsoft.CodeAnalysis.Workspaces assembly is not provided during command line compilation scenarios, so references to it could cause the compiler extension to behave unpredictably. (https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md)

so these are the code changes only, based on search/replace. Could you try applying it as a patch to source-build? https://github.com/dotnet/aspnetcore/pull/58769.patch

[am11]

is this actually failing currently? Expected to fail if we update the compiler? Or ...?

The VMR legs failures in linked issue are related: https://github.com/dotnet/sdk/runs/32426310644

To make sure that we have covered all the potential issues we should update Versions.props and Version.Details.xml as part of this PR with 4.13.0-1.24510.9 (currently used by runtime and sdk), but when I tried there were some dependency issues which I'm not sure how to resolve #58769 (comment).

[mgravell]

Relevant context is in this comment - basically, new extension method overloads conflicting, specifically Reverse.

[mgravell]

The changes LGTM; can I check, however; is this actually failing currently? Expected to fail if we update the compiler? Or ...?

[ViktorHofer]

Yes, this is causing failures in dotnet/sdk#43015 which updates the SDK and builds the aspnetcore repo as part of the VMR. Let's get this merged to unblock that PR. We can always react to more feedback in a follow-up.