Cleanup bc layers #10764
Merged
Cleanup bc layers #10764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Jun 5, 2023
| 'Passing an instance of %s to %s is deprecated, please pass a %s instance instead.', | ||
| $metadata::class, | ||
| throw new TypeError(sprintf( | ||
| 'Argument #2 passed to %s() must be an instance of %s, %s given.', |
There was a problem hiding this comment.
I didn't provide an upgrade note for that one because it's not precisely a realistic scenario to provide anything else than an ORM metadata instance to this method.
derrabus
approved these changes
Jun 5, 2023
| __METHOD__, | ||
| ClassMetadata::class, | ||
| ); | ||
| $metadata::class, |
There was a problem hiding this comment.
Suggested change
| $metadata::class, | |
| get_debug_type($metadata), |
When embedding a class into a message, we should prefer get_debug_type() over ::class because the former plays more nicely with anonymous classes.
Comment on lines
38
to
40
| * @param bool $reportFieldsWhereDeclared no-op, to be removed in 4.0 | ||
| */ | ||
| public function __construct(array $paths, bool $reportFieldsWhereDeclared = false) |
There was a problem hiding this comment.
Suggested change
| * @param bool $reportFieldsWhereDeclared no-op, to be removed in 4.0 | |
| */ | |
| public function __construct(array $paths, bool $reportFieldsWhereDeclared = false) | |
| * @param true $reportFieldsWhereDeclared no-op, to be removed in 4.0 | |
| */ | |
| public function __construct(array $paths, bool $reportFieldsWhereDeclared = true) |
Also, let's throw if false has been passed explicitly.
There was a problem hiding this comment.
Let's switch to checking func_num_args() when deprecating this on 3.1.x
derrabus
requested changes
Jun 5, 2023
48bee72 to
575d0c0
Compare
|
@mpdude please review |
derrabus
approved these changes
Jun 6, 2023
|
Thanks for reviewing anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.