Reject non instances of ORM\ClassMetadata

Author: greg0ire

lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php

@@ -10,14 +10,14 @@
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Types\Type;
 use Doctrine\DBAL\Types\Types;
-use Doctrine\Deprecations\Deprecation;
 use Doctrine\Inflector\Inflector;
 use Doctrine\Inflector\InflectorFactory;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\MappingException;
 use Doctrine\Persistence\Mapping\ClassMetadata as PersistenceClassMetadata;
 use Doctrine\Persistence\Mapping\Driver\MappingDriver;
 use InvalidArgumentException;
+use TypeError;
 
 use function array_diff;
 use function array_keys;
@@ -28,6 +28,7 @@
 use function in_array;
 use function preg_replace;
 use function sort;
+use function sprintf;
 use function strtolower;
 
 /**
@@ -157,14 +158,12 @@ public function setInflector(Inflector $inflector): void
     public function loadMetadataForClass(string $className, PersistenceClassMetadata $metadata): void
     {
         if (! $metadata instanceof ClassMetadata) {
-            Deprecation::trigger(
-                'doctrine/orm',
-                'https://github.com/doctrine/orm/pull/249',
-                'Passing an instance of %s to %s is deprecated, please pass a %s instance instead.',
-                $metadata::class,
+            throw new TypeError(sprintf(
+                'Argument #2 passed to %s() must be an instance of %s, %s given.',
                 __METHOD__,
                 ClassMetadata::class,
-            );
+                $metadata::class,
+            ));
         }
 
         $this->reverseEngineerMappingFromDatabase();