Require PHP 7.4 #2466
Merged
Require PHP 7.4 #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3278cc to
e003c1d
Compare
|
Do we have any outstanding todos or PHP version checks that could be removed now? They should be removed along with this PR if present. All other improvements are better than fine in separate PRs :) |
|
Yes, we definitely still have some PHP version checks in the code. I will be solving them step by step, also planning to incorporate Rector to speed things up but that will come in separate PRs so it's easier to review. |
|
Cool, thanks. I've removed now-obsolete required checks :) |
greg0ire
approved these changes
Sep 29, 2022
derrabus
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps minimal PHP version to 7.4 and PHPUnit to 9.x