Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Bump minimal PHP version to 7.4 #2464

Closed
4 tasks done
malarzm opened this issue Sep 27, 2022 · 4 comments
Closed
4 tasks done

[RFC] Bump minimal PHP version to 7.4 #2464

malarzm opened this issue Sep 27, 2022 · 4 comments
Labels
Milestone

Comments

@malarzm
Copy link
Member

malarzm commented Sep 27, 2022

https://packagist.org/packages/doctrine/mongodb-odm/php-stats#2 shows that ~95% of 2.x users are using at least PHP 7.4 while the minimum required version in 7.2. Given 7.2 -> 7.4 is not bumping for the sake of bumping but would allow us to modernize our code this is a minimum bump we should consider for next minor version.

  • Bump minimal PHP version in composer.json
  • Remove PHP version checks for PHP 7.x
  • Add typed properties and default values where applicable
  • Migrate the code to use latest syntax features (arrow functions, etc)
@malarzm malarzm added the Task label Sep 27, 2022
@malarzm malarzm added this to the 2.5.0 milestone Sep 27, 2022
@IonBazan
Copy link
Member

By all means! Bumping to 7.4 would give us many syntax improvements but some breaking changes may occur when using covariance/contravariance.

@franmomu
Copy link
Contributor

is anything else missing here? 🤔

It would be nice to release 2.5 to unlock other libraries to add support for new doctrine/* package versions (like DoctrineMongoDBBundle).

We can finish #2489 and leave the removal of annotation dependency for 2.6.

@alcaeus
Copy link
Member

alcaeus commented Feb 15, 2023

No objections from my end. Happy to defer making use of additional 7.4 features (i.e. typed properties) in a future minor version.

@IonBazan
Copy link
Member

IonBazan commented Mar 1, 2023

Closing as implemented in linked PRs.

@IonBazan IonBazan closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants