Schema manager should also know how to handle shard key on reference #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Mar 9, 2018
| ->expects($this->at(0)) | ||
| ->method('command') | ||
| ->with(array('enableSharding' => $dbName)) | ||
| ->willReturn(array('ok' => 1)); |
There was a problem hiding this comment.
Why is this mocked instead of sending actual command and inspecting schema later?
There was a problem hiding this comment.
Most tests in schema manager build on mocks. These are scheduled for a refactoring in master branch since the mocks are no longer valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #1693 to the 1.2 branch. My initial hunch regarding field name translation was correct - this was an additional issue affecting all shard keys that have a different database name. This is also fixed in this PR.
// cc @notrix