-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema manager should handle shard key on reference #1693
Conversation
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review below. Please note that the merge may take a few days (regardless of review issues) as I'm currently in the process of wrapping up the MongoDB driver switch and I don't want to endlessly rebase branches. Thanks for understanding.
d9142d2
to
8a50e15
Compare
@notrix after an eternity without updates, I finally managed to revisit this. I've created #1748 to fix this issue in the 1.2 branch, to be released in 1.2.2 soon. I've rebased this branch on top of the current master to spare you the trouble - with the Thanks for your contribution! 🎉 |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
8a50e15
to
7c3d409
Compare
|
||
/** | ||
* @ODM\Document(collection="sharded.users") | ||
* @ODM\ShardKey(keys={"user"="asc"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @notrix, I had to change this from desc
to asc
as the test failed with the error that the shard key would could only be ascending or hashed.
Schema manager should also know how to handle shard key on reference
This PR is part of sharding key on reference fix. Referencing another PR #1687