[Bug] @EmbedOne @EmbedMany without targetDocument on 2.0@beta-1

[Dragonqos]

Bug Report

Trying to create EmbedOne/EmbedMany Relation with discriminatorMap and discriminatorType only, getting error on Metadata parse:

Q	A
BC Break	yes/no
Version	2.0.0-beta1

Summary

When we calling $class = $metadata->getAssociationTargetClass($property); from file api-platform/core/src/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractor.php:69 and targetDocument is not defined method should return NULL instead of STRING, but that action was restricted by type hint in file MongoDB/Mapping/ClassMetadata.php:1743

In ClassMetadata.php line 1743:
  [Symfony\Component\Debug\Exception\FatalThrowableError]
  Return value of Doctrine\ODM\MongoDB\Mapping\ClassMetadata::getAssociationTargetClass() must be of the type string, null returned
Exception trace:
 () at /var/www/channel/vendor/doctrine/mongodb-odm/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php:1743
 Doctrine\ODM\MongoDB\Mapping\ClassMetadata->getAssociationTargetClass() at /var/www/channel/vendor/api-platform/core/src/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractor.php:69

Current behavior

public function getAssociationTargetClass($assocName) : string
returns STRING or throw FatalError

How to reproduce

<?php

namespace App\Tests;

use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
use Doctrine\ODM\MongoDB\Mapping\Driver\AnnotationDriver;
use PHPUnit\Framework\TestCase;

class DiscriminatorTest extends TestCase
{
    public function testGettingMetadataForEmbededWithoutTargetDocument()
    {
        $classMetadata = $this->loadMetadata(EmbedWithoutTargetDocument::class);

        self::assertEquals([
            "fieldName" => "embeddedPhonenumber",
            "type" => "one",
            "embedded" => true,
            "targetDocument" => null,
            "discriminatorField" => "discr",
            "discriminatorMap" => [
                "home" => "App\Tests\HomePhonenumber",
            ],
            "defaultDiscriminatorValue" => null,
            "name" => "embeddedPhonenumber",
            "nullable" => false,
            "options" => [],
            "strategy" => "set",
            "notSaved" => false,
            "value" => null,
            "isCascadeRemove" => true,
            "isCascadePersist" => true,
            "isCascadeRefresh" => true,
            "isCascadeMerge" => true,
            "isCascadeDetach" => true,
            "association" => 3,
            "isOwningSide" => true,
            "isInverseSide" => false
        ], $classMetadata->getFieldMapping('embeddedPhonenumber'));

        self::assertNULL($classMetadata->getAssociationTargetClass('embeddedPhonenumber'));
    }

    protected function loadMetadata($className): ClassMetadata
    {
        $mappingDriver = $this->_loadDriver();
        $class = new ClassMetadata($className);
        $mappingDriver->loadMetadataForClass($className, $class);

        return $class;
    }

    protected function _loadDriver()
    {
        $reader = new AnnotationReader();
        return new AnnotationDriver($reader);
    }
}

/**
 * @ODM\Document
 */
class EmbedWithoutTargetDocument
{
    /** @ODM\Id */
    public $id;

    /** @ODM\EmbedOne( 
      * discriminatorField="discr", 
      * discriminatorMap={"home"=HomePhonenumber::class} ) 
      */
    public $embeddedPhonenumber;
}

/**
 * @ODM\Document
 */
class HomePhonenumber
{
    /** @ODM\Id */
    public $id;

    /** @ODM\Field(type="string") */
    public $number;
}

Expected behavior

public function getAssociationTargetClass($assocName) : ?string
returns STRING or NULL

[malarzm]

I believe we could treat the only entry discriminatorMap as it'd be defined as targetClass. @alcaeus thoughts on this?

Offhand, @Dragonqos what's the use case for an embedded document with one entry? Is it being prepared for the future extension?

[Dragonqos]

One entry in discriminatorMap is just for example for test. My application has at least 5 embedded document.

[alcaeus]

@Dragonqos thanks for providing a test case. You are correct, an association without a target document is perfectly valid, so we should fix the wrong typehint.

[Dragonqos]

Hope it will be fixed asap)

[Dragonqos]

Any updates on this?

[malarzm]

@Dragonqos I've just submitted #1983 with a fix

[alcaeus]

#1983 was merged, closing here. Thanks for bringing this up @Dragonqos!