Merge pull request #1983 from malarzm/gh-1961

Allow returning null from getAssociationTargetClass
doctrine · Mar 29, 2019 · c1b0137 · c1b0137
2 parents 7f0e11e + d251ea5
commit c1b0137
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php b/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php
@@ -1737,7 +1737,7 @@ public function getTypeOfField($fieldName) : ?string
     /**
      * {@inheritDoc}
      */
-    public function getAssociationTargetClass($assocName) : string
+    public function getAssociationTargetClass($assocName) : ?string
     {
         if (! isset($this->associationMappings[$assocName])) {
             throw new InvalidArgumentException("Association name expected, '" . $assocName . "' is not an association.");

diff --git a/tests/Doctrine/ODM/MongoDB/Tests/Mapping/ClassMetadataTest.php b/tests/Doctrine/ODM/MongoDB/Tests/Mapping/ClassMetadataTest.php
@@ -138,6 +138,19 @@ public function testMapManyToManyJoinTableDefaults()
         $this->assertInternalType('array', $assoc);
     }
 
+    public function testGetAssociationTargetClassWithoutTargetDocument()
+    {
+        $cm = new ClassMetadata(CmsUser::class);
+        $cm->mapManyEmbedded(
+            [
+                'fieldName' => 'groups',
+                'targetDocument' => null,
+            ]
+        );
+
+        $this->assertNull($cm->getAssociationTargetClass('groups'));
+    }
+
     /**
      * @group DDC-115
      */