v9.11.0 Bump peter-evans/create-pull-request from 3.14.0 to 4 #5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the clean fails, the rebuild never happens, and reading issues from the rebuild log needs to be skipped.
Fix failure to report issues when clean fails
Fix for issue 5049. Caching search results needs to include the current culture in the key.
Fix for issue #5047. This will allow to optionally remove the rel attribute from privacy and terms links. Default is still "rel=nofollow" but it could now either be changed or removed entirely from the ascx file. Unfortunately the asp.net control doesn't have a rel attribute, so we have to add it ourselves. Added Rel attribute to Privacy and Terms class and added rel="nofollow" to privacy.ascx and terms.ascx skin file.
Fixed unit test to use the new key including culture.
Allows localization of search categories
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Added missing semicolons.
Allows optionally removing rel from privacy and terms
Fix not reporting errors or warnings from build
…e skin Set the rel attribute of the hyperlink only if there is either no value set in the skin or a non blank value defined in the skin. If it is set to rel="" in the skin, the hyperlink will be rendered without a rel attribute.
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Allow removal of rel for Terms and Privacy skin objects
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3.14.0 to 4. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v3.14.0...v4) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…eter-evans/create-pull-request-4 Bump peter-evans/create-pull-request from 3.14.0 to 4
bdukes
approved these changes
Mar 25, 2022
valadas
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying #5059 to release/9.11.0
Bumps peter-evans/create-pull-request from 3.14.0 to 4.
Release notes
Sourced from peter-evans/create-pull-request's releases.
Commits
d6d5519v4 (#1099)0e8dfbddocs: update guidelinesffa8cc2docs: Skip follow-up steps if there is no pull request (#1083)00fb690docs: Document how to improve close-and-reopen user experience (#1084)2fe7e77docs: Add word "permissions" (#1082)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting .
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: